From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753933AbbCBNBQ (ORCPT ); Mon, 2 Mar 2015 08:01:16 -0500 Received: from canardo.mork.no ([148.122.252.1]:33211 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbbCBNBN convert rfc822-to-8bit (ORCPT ); Mon, 2 Mar 2015 08:01:13 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Jani Nikula Cc: Imre Deak , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Ville =?utf-8?B?U3lyasOkbMOk?= , David Weinehall Subject: Re: [PATCH v2] drm/i915: gen4: work around hang during hibernation Organization: m References: <1425294281-7297-1-git-send-email-imre.deak@intel.com> <87385n60re.fsf@intel.com> Date: Mon, 02 Mar 2015 14:00:58 +0100 In-Reply-To: <87385n60re.fsf@intel.com> (Jani Nikula's message of "Mon, 02 Mar 2015 14:29:25 +0200") Message-ID: <87sidn8sfp.fsf@nemi.mork.no> User-Agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.3.9 (canardo.mork.no [IPv6:2001:4641::1]); Mon, 02 Mar 2015 14:01:02 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jani Nikula writes: > On Mon, 02 Mar 2015, Imre Deak wrote: >> Bjørn reported that his machine hang during hibernation and eventually >> bisected the problem to the following commit: >> >> commit da2bc1b9db3351addd293e5b82757efe1f77ed1d >> Author: Imre Deak >> Date: Thu Oct 23 19:23:26 2014 +0300 >> >> drm/i915: add poweroff_late handler >> >> The problem seems to be that after the kernel puts the device into D3 >> the BIOS still tries to access it, or otherwise assumes that it's in D0. >> This is clearly bogus, since ACPI mandates that devices are put into D3 >> by the OSPM if they are not wake-up sources. In the future we want to >> unify more of the driver's runtime and system suspend paths, for example >> by skipping all the system suspend/hibernation hooks if the device is >> runtime suspended already. Accordingly for all other platforms the goal >> is still to properly power down the device during hibernation. >> >> v2: >> - Another GEN4 Lenovo laptop had the same issue, while platforms from >> other vendors (including mobile and desktop, GEN4 and non-GEN4) seem >> to work fine. Based on this apply the workaround on all GEN4 Lenovo >> platforms. >> - add code comment about failing platforms (Ville) >> >> Reference: http://lists.freedesktop.org/archives/intel-gfx/2015-February/060633.html >> Reported-and-bisected-by: Bjørn Mork >> Signed-off-by: Imre Deak > > Bjørn, I would really appreciate your Tested-by on this patch before I > queue it for v4.0 and cc: stable for v3.19. No problem. This version still works fine for me. Feel free to add Tested-by: Bjørn Mork Bjørn