From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbaI2JNm (ORCPT ); Mon, 29 Sep 2014 05:13:42 -0400 Received: from max.feld.cvut.cz ([147.32.192.36]:40057 "EHLO max.feld.cvut.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbaI2JNl (ORCPT ); Mon, 29 Sep 2014 05:13:41 -0400 From: Michal Sojka To: Robert Baldyga , linux-usb@vger.kernel.org Cc: Alan Stern , Bryan Wu , Felipe Balbi , Greg Kroah-Hartman , Linux LED Subsystem , linux-kernel@vger.kernel.org, michal.vokac@comap.cz Subject: Re: [PATCH v6 2/4] usb: gadget: Refactor request completion In-Reply-To: <54291D3A.6070106@samsung.com> References: <1411591401-5874-1-git-send-email-sojka@merica.cz> <1411591401-5874-3-git-send-email-sojka@merica.cz> <54291D3A.6070106@samsung.com> User-Agent: Notmuch/0.18.1+101~g56b0ff0 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Mon, 29 Sep 2014 11:13:33 +0200 Message-ID: <87sijassaq.fsf@steelpick.2x.cz> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 29 2014, Robert Baldyga wrote: > Hi, > > On 09/24/2014 10:43 PM, Michal Sojka wrote: >> Use the recently introduced usb_gadget_giveback_request() in favor of >> direct invocation of the completion routine. >> >> All places in drivers/usb/ matching "[-.]complete(" were replaced with a >> call to usb_gadget_giveback_request(). This was compile-tested with all >> ARM drivers enabled and runtime-tested for musb. >> >> Signed-off-by: Michal Sojka [...] >> diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c >> index 7324308..dd18ea3 100644 >> --- a/drivers/usb/gadget/udc/fsl_qe_udc.c >> +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c >> @@ -118,10 +118,7 @@ static void done(struct qe_ep *ep, struct qe_req *req, int status) >> ep->stopped = 1; >> spin_unlock(&udc->lock); >> >> - /* this complete() should a func implemented by gadget layer, >> - * eg fsg->bulk_in_complete() */ >> - if (req->req.complete) >> - req->req.complete(&ep->ep, &req->req); >> + usb_gadget_giveback_request(&ep->ep, &req->req); > > It looks like you have omitted if() statement. Are you sure that request > has set complete() callback? Yes, see the rest of the thread. This was suggested by other reviewers. -Michal