From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757297AbaHZGqf (ORCPT ); Tue, 26 Aug 2014 02:46:35 -0400 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:36196 "EHLO lgemrelse7q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755391AbaHZGqe (ORCPT ); Tue, 26 Aug 2014 02:46:34 -0400 X-Original-SENDERIP: 10.177.220.181 X-Original-MAILFROM: namhyung@gmail.com From: Namhyung Kim To: John Spencer Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf Makefile: fix GNU-only grep usage References: <53FB9040.8060802@barfooze.de> Date: Tue, 26 Aug 2014 15:46:32 +0900 In-Reply-To: <53FB9040.8060802@barfooze.de> (John Spencer's message of "Mon, 25 Aug 2014 21:36:32 +0200") Message-ID: <87sikjbvef.fsf@sejong.aot.lge.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, You'd better to CC the lkml (linux-kernel@vger.kernel.org) for the perf patches to get reviewed by other developers. I'm copying to the list this time. On Mon, 25 Aug 2014 21:36:32 +0200, John Spencer wrote: > From efa79d5b7bc750369332a3a34442573af7b1b35c Mon Sep 17 00:00:00 2001 > From: John Spencer > Date: Mon, 25 Aug 2014 21:24:30 +0200 > Subject: [PATCH 1/2] perf Makefile: fix GNU-only grep usage > > this makes it work with non-GNU grep's as well. > > Signed-off-by: John Spencer Acked-by: Namhyung Kim Thanks, Namhyung > > --- > tools/perf/config/utilities.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/config/utilities.mak b/tools/perf/config/utilities.mak > index 4d985e0..7076a62 100644 > --- a/tools/perf/config/utilities.mak > +++ b/tools/perf/config/utilities.mak > @@ -132,7 +132,7 @@ endef > # > # Usage: bool-value = $(call is-absolute,path) > # > -is-absolute = $(shell echo $(shell-sq) | grep ^/ -q && echo y) > +is-absolute = $(shell echo $(shell-sq) | grep -q ^/ && echo y) > > # lookup > #