mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Dinh.Nguyen@freescale.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
	u.kleine-koenig@pengutronix.de, ra5478@freescale.com,
	xiao-lizhang@freescale.com, festevam@gmail.com
Subject: Re: [PATCHv3 3/3] ARM: mx51: Add support for low power suspend on MX51
Date: Thu, 17 Mar 2011 09:29:03 +0100	[thread overview]
Message-ID: <87sjumrvzk.fsf@lebrac.rtp-net.org> (raw)
In-Reply-To: <20110317082106.GT29521@pengutronix.de> (Sascha Hauer's message of "Thu, 17 Mar 2011 09:21:06 +0100")

Sascha Hauer <s.hauer@pengutronix.de> writes:

Hi,

> On Wed, Mar 16, 2011 at 03:03:07PM -0500, Dinh.Nguyen@freescale.com wrote:
>> +
>> +struct clk *gpc_dvfs_clk;
>> +
>> +static int mx5_suspend_enter(suspend_state_t state)
>> +{
>> +	if (gpc_dvfs_clk == NULL)
>> +		gpc_dvfs_clk = clk_get(NULL, "gpc_dvfs_clk");
>
> clk_get can fail and NULL can be a valid clock.

So, I guess one may want to fail here if one can't get the clock. The
suspend will fail in hard to debug way if this clock is not enabled
at this point.

Arnaud

  reply	other threads:[~2011-03-17  8:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 20:03 [PATCHv3 1/3] ARM: mx51: Add entry for gpc_dvfs_clk Dinh.Nguyen
2011-03-16 20:03 ` [PATCHv3 2/3] ARM: mx51: Implement code to allow mx51 to enter WFI Dinh.Nguyen
2011-03-16 20:03   ` [PATCHv3 3/3] ARM: mx51: Add support for low power suspend on MX51 Dinh.Nguyen
2011-03-17  8:21     ` Sascha Hauer
2011-03-17  8:29       ` Arnaud Patard [this message]
2011-03-17 10:31     ` Lothar Waßmann
2011-03-17  8:18   ` [PATCHv3 2/3] ARM: mx51: Implement code to allow mx51 to enter WFI Sascha Hauer
2011-03-17 16:52     ` Nguyen Dinh-R00091
2011-03-17 21:12       ` Uwe Kleine-König
2011-03-17 10:21   ` Russell King - ARM Linux
2011-03-17  8:00 ` [PATCHv3 1/3] ARM: mx51: Add entry for gpc_dvfs_clk Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjumrvzk.fsf@lebrac.rtp-net.org \
    --to=arnaud.patard@rtp-net.org \
    --cc=Dinh.Nguyen@freescale.com \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=ra5478@freescale.com \
    --cc=s.hauer@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=xiao-lizhang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®