From: Alex Tomas <bzzz@tmi.comex.ru>
To: Andrew Morton <akpm@digeo.com>
Cc: Alex Tomas <bzzz@tmi.comex.ru>,
sct@redhat.com, linux-kernel@vger.kernel.org,
ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] [RFC] probably bug in current ext3/jbd
Date: Wed, 21 May 2003 20:45:33 +0000 [thread overview]
Message-ID: <87smr8c9le.fsf@gw.home.net> (raw)
In-Reply-To: <20030521093848.59ada625.akpm@digeo.com> (Andrew Morton's message of "Wed, 21 May 2003 09:38:48 -0700")
>>>>> Andrew Morton (AM) writes:
AM> Alex Tomas <bzzz@tmi.comex.ru> wrote:
>>
>> looks Andrew Morton should return BKL in ext3_get_block_handle() in -mm tree?
>> this BKL protects ext3_alloc_branch() -> ext3_alloc_block() -> ext3_new_block()
>> call chain. or we may implement new protection schema where each jh has some
>> reference alike 'used by transaction N'
AM> Can this be solved by spinlocking the relevant buffer_head, in a similar
AM> way to your recent changes to journal_add_journal_head()?
yes, we may protect it by such lock, but this lock have to be held all time
ext3_new_block() uses some b_committed_data because last one may be freed
during current ext3_new_block(). I don't think it's good.
probably, another solution is do not free b_committed_data if it's referenced
by new transaction and make copy from b_frozen instead of freeing it.
next prev parent reply other threads:[~2003-05-21 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-18 17:21 Alex Tomas
2003-05-19 20:34 ` [Ext2-devel] " Stephen C. Tweedie
2003-05-20 0:46 ` Alex Tomas
2003-05-19 20:51 ` Stephen C. Tweedie
2003-05-20 0:58 ` Alex Tomas
2003-05-20 16:06 ` Alex Tomas
2003-05-21 16:38 ` Andrew Morton
2003-05-21 20:45 ` Alex Tomas [this message]
2003-05-21 16:59 ` Andrew Morton
[not found] ` <m3brxwe2lr.fsf@lexa.home.net>
[not found] ` <20030521103737.52eddeb3.akpm@digeo.com>
[not found] ` <87n0hgc6s6.fsf@gw.home.net>
[not found] ` <20030521105011.2d316baf.akpm@digeo.com>
[not found] ` <87k7ckc5z2.fsf@gw.home.net>
[not found] ` <20030521143140.3aaa86ba.akpm@digeo.com>
2003-05-23 11:08 ` Alex Tomas
2003-05-23 8:49 ` Andrew Morton
2003-05-23 12:49 ` Alex Tomas
2003-05-23 11:20 ` [RFC] probably invalid accounting in jbd Alex Tomas
2003-05-23 8:26 ` Andrew Morton
2003-05-23 16:02 ` [Ext2-devel] " Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87smr8c9le.fsf@gw.home.net \
--to=bzzz@tmi.comex.ru \
--cc=akpm@digeo.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®