From: Takashi Iwai <tiwai@suse.de>
To: Wang Yan <wangyan01@kylinos.cn>
Cc: perex@perex.cz, tiwai@suse.com, runyu.xiao@seu.edu.cn,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: mtpav: restore negation dropped in guard() conversion
Date: Tue, 20 Oct 2026 12:58:13 +0200 [thread overview]
Message-ID: <87tsmghc56.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261020090959.570101-1-wangyan01@kylinos.cn>
On Tue, 20 Oct 2026 11:09:59 +0200,
Wang Yan wrote:
>
> commit 316e0074ecdc ("ALSA: mtpav: Use guard() for spin locks")
> claims to be "Merely code refactoring, and no behavior change", but
> it accidentally dropped the "!" from
>
> if (! (portp->mode & MTPAV_MODE_OUTPUT_TRIGGERED))
>
> in snd_mtpav_output_trigger().
>
> Restore the negation.
>
> Signed-off-by: Wang Yan <wangyan01@kylinos.cn>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-10-20 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 9:09 Wang Yan
2026-10-20 10:58 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsmghc56.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=runyu.xiao@seu.edu.cn \
--cc=tiwai@suse.com \
--cc=wangyan01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®