mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Zhang Heng <zhangheng@kylinos.cn>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Baojun Xu <baojun.xu@ti.com>,
	Antheas Kapenekakis <lkml@antheas.dev>,
	Aleksei Arsenev <alesharik4@gmail.com>
Subject: Re: [PATCH] ALSA: hda/realtek: Fix square wave output on ASUS Strix G615LR
Date: Mon, 28 Sep 2026 13:37:30 +0200	[thread overview]
Message-ID: <87tsn961z9.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260923121640.272509-1-zhangheng@kylinos.cn>

On Wed, 23 Sep 2026 14:16:40 +0200,
Zhang Heng wrote:
> 
> ASUS ROG Strix G16 G615LR (PCI SSID 1043:3f20) outputs a loud
> full-scale square wave from internal speakers since the TAS2781
> amplifier driver started loading. The quirk was using
> ALC287_FIXUP_TXNW2781_I2C which chains to the ThinkPad headset
> jack fixup, but this is an ASUS device that should use
> ALC287_FIXUP_TXNW2781_I2C_ASUS which chains to ALC294_FIXUP_ASUS_SPK
> for proper EAPD and pin configuration.
> 
> Fixes: f7cede182c96 ("ALSA: hda/realtek: Add Asus quirk for TAS amplifiers")
> Cc: stable@vger.kernel.org
> Cc: Baojun Xu <baojun.xu@ti.com>
> Cc: Antheas Kapenekakis <lkml@antheas.dev>
> Reported-by: Aleksei Arsenev <alesharik4@gmail.com>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=222045
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
> ---
> Baojun, Antheas: several other ASUS Strix Gxx5 entries (0x3ee0, 0x3ef0,
> 0x3f00, 0x3f10, 0x3f30) are still using ALC287_FIXUP_TXNW2781_I2C (the
> non-ASUS variant that chains to the ThinkPad fixup). Could you check
> whether they also need to be changed to ALC287_FIXUP_TXNW2781_I2C_ASUS?
> Ideally with testing on the affected hardware if possible.

Applied now.  Thanks.


Takashi

  reply	other threads:[~2026-09-28 11:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 12:16 Zhang Heng
2026-09-28 11:37 ` Takashi Iwai [this message]
2026-09-28 12:05 ` Antheas Kapenekakis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tsn961z9.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alesharik4@gmail.com \
    --cc=baojun.xu@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=lkml@antheas.dev \
    --cc=perex@perex.cz \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=zhangheng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®