From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B02730FC1E for ; Wed, 15 Jul 2026 14:41:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784126473; cv=none; b=B2tcwNgvdPPLOHTWNyy1FOWP+bzz/WTIV9iuH6uUS5goWvX+R+6Il/Ci4b1RZXNO/D8o2TjscBno90mZuaev3aYrkEJukjVOkpBwmXM04zu9el/s1IIRxiLaXDhDxARNqKNsX8Kv3it3O1EAsUgiYC2hjxuQYepM6lgLv5qXuG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784126473; c=relaxed/simple; bh=JMU7j6ZRFI+XAe7bPt1QaenjDQuqENIg6Q2LkoEmceI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=kVMVLcEi2wZEBrX3m9IKXG0Y9NsakbTgDFm3CN+5NOwJzBVouyhBunF+QPkocHThipAZer6Zwl/DHzjN+X6jcVm1k/QFdFS/AkPWZ7ZbCQhLRpwCOyNgsx8WCmfRWKGfeY6ZhQJI2aYrRWJV+71HYip2C4AyUptyFkhSmWwOKfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=EUQAnDvo; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=Bbh2VouB; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="EUQAnDvo"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Bbh2VouB" From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1784126470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=edLQL90SDooS4rTqr6+24j08SKV0EbGiax+3lw1KoFU=; b=EUQAnDvoic0U79rxSrquzyb9eBZl3Zh8w0rYzU8dlwPhZGeKi9VMX04bXTwFva7cG/+93t H0QR4FIyLFIro7Xn56C3nekZSMFEHDkCi/H0DU9uj4PpbIUkap+JR1aDM9P/W0eE6bZJoI 7Gz9RO/xGnwnxH4xX9PMZsxp1gkHQlW0daKD3r+6g7WCqXF4BLqi/tL09kDXqL7qJYVuMg dfYFad98N+K7ENJLqOsGiYAcjNXb0ppzoLhBH7OHY/MF4/kxfU33EsmGgOySaNIkaRwE4F 2gyN0XD9kQVz4rCo41DZ88Df+lgvWWRovjxqlfUSqFSbCX8z1QYGfNfnYjUP3A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1784126470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=edLQL90SDooS4rTqr6+24j08SKV0EbGiax+3lw1KoFU=; b=Bbh2VouBq4BoJ29U6GU04WwWsZnPi7UqEkUGJYZwnsx0hHvj0DiQU/cO+G4erGPPmdGp/F QF5dSvKRT5kJbeCg== To: Petr Mladek Cc: Sergey Senozhatsky , Steven Rostedt , Marcos Paulo de Souza , Chris Down , Naveen Kumar Chaudhary , linux-kernel@vger.kernel.org, Petr Mladek , Sashiko Subject: Re: [PATCH v4 06/11] console/braille: Lock console->setup() call during the registration In-Reply-To: <20260604101459.393162-7-pmladek@suse.com> References: <20260604101459.393162-1-pmladek@suse.com> <20260604101459.393162-7-pmladek@suse.com> Date: Wed, 15 Jul 2026 16:47:10 +0206 Message-ID: <87tsq0wc1l.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 2026-06-04, Petr Mladek wrote: > diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c > index 7b324329882f..9ed3abffb687 100644 > --- a/drivers/accessibility/braille/braille_console.c > +++ b/drivers/accessibility/braille/braille_console.c > @@ -356,7 +356,9 @@ int braille_register_console(struct console *console, int index, > if (braille_co) > return -ENODEV; > if (console->setup) { > + console_lock(); > ret = console->setup(console, console_options); > + console_unlock(); > if (ret != 0) > return ret; > } This block is open coding an existing helper that was created for exactly this purpose. The code could look like: ret = console_call_setup(console, console_options); if (ret != 0) return ret; ...if console_call_setup() was (for example) a static inline in console.h. For this patch as-is: Acked-by: John Ogness