From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 841F62BF3D7 for ; Thu, 26 Feb 2026 07:58:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772092713; cv=none; b=hqc3aDI3PbC+sv8Yg0DzSRlBrAX9Tr9pWIz5cxRoPO1b8ubYqklpqRLsFx/Nw3FzKPe/dvpKDLAyr8ocxJmPVS50PTogjCo3VuYq5qjrgrmxP4a5YJXOu0NmoxEixvNhbN5UXFX6UxzaIjjQGi5wdHJaeN4ZY8p8KQM8DmYRECM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772092713; c=relaxed/simple; bh=8zFACv70vxFbVMIAYPOpZegIK+CVB6J8NxsficH+XMc=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=gNPPKT/01UgYRC8nxBFDDGfuw+pPSmcqDGeGrhpSIW9Jm+qy6IAJe+u09/qAEdJ+YYYfhlui7lgug3cWC5XSh4jnTxdzc2dGwKBUwaV8K6U62SSdnlxJCLsV9XVl0TIGmgHX3vIJjwaKJQIbwtp5KRLOn6No85dA47Xm6HZA+uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZJ2OurkD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qSlyfwsO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZJ2OurkD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qSlyfwsO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772092711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6HSMbdMfEtsXEv7wJXDWJr6XKZTaO2UazUOToDtNJT4=; b=ZJ2OurkD9BLjOWMhOyTXnqZ1cgnVeWx/JZv5qkPEQ4wuAV33/I8Q3BZ5oB6koshfc8QYKk v5rq7ONIL9IeVUAA/BqiVXAathe1GkK/VchQkP9A3fkr2uQX0snrzfVDimC7HOBC68FnPc HjMapXsuigw0ttDkqOCzjLuH7ee3sl8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-2zCgbTmGNCiB9BfU5VhqeQ-1; Thu, 26 Feb 2026 02:58:29 -0500 X-MC-Unique: 2zCgbTmGNCiB9BfU5VhqeQ-1 X-Mimecast-MFC-AGG-ID: 2zCgbTmGNCiB9BfU5VhqeQ_1772092709 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4837246211bso5435755e9.0 for ; Wed, 25 Feb 2026 23:58:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772092709; x=1772697509; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=6HSMbdMfEtsXEv7wJXDWJr6XKZTaO2UazUOToDtNJT4=; b=qSlyfwsOYhIozUXohfMOF9f0xYVpwqvYjZlW5tj43RI/xee/R+2m9l5E0ZDaE3F/Th HAf0u8Gm/k9AgPEFJ1wnWp9i0KKRN6KdUjbw60vgkK9EvUS5pdSuWHNv+bYh/CpB9L+p eBdZlWJUgKkbqQHwx7u2ZSP0zvWy3qRdkMD3AfhO/71x0GLCP+3PHeFl3Pngj5mXiUrj yybjMKWQ/fIvHJYc9/eJDNTzMRnZ/d0EAB3m09U3fv0Nr+MjfXmjSjnd+syanXXcMpsn AoaSqPfperQuVZJMRdwDtO9MBbNJiPywRytp3pxuje75xSeq0wkuhAvzoDuxkFEe5Iib nLhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772092709; x=1772697509; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6HSMbdMfEtsXEv7wJXDWJr6XKZTaO2UazUOToDtNJT4=; b=JBgb/bCXXyDLVTN5IAbZfxW1GrNdWolgLoQHxJaBEfmCU2fuv8brXApVGAIop/G8Uq WtDIuteN23wnDSg5k8VMlkVl/f6yo+WTxVG8nqLYHbXhHQSwrW9wEZy/wDyufR0wHKB9 0LdiAZu+QAgOuq9CvDUaPhT4RjWK3pRaqtyTSz3eSeBdgSkJbBj9ryxVwHB2sAY2aDEP WHqM+XE/j+81E17lkiFOY7LRhrzt6ON/RaQzxDHn3yaH1yVcFqbS9fNJ0E8QUZinMiQe wnDDkztui5mAm5SU+90/B7TmNMoqx3mnwlWe3vAxwkjGVy78QrbZcsP2rTtTp8qA7kyT CAaw== X-Forwarded-Encrypted: i=1; AJvYcCV35/z4VRb/YPCJbGwXySm2YzwyjRNkmCcfLBRYqCFvXU4VEHOm5u5LvH+noPBBeLqTQ0jQ4WG74g5GocM=@vger.kernel.org X-Gm-Message-State: AOJu0YyZHMf9B7BgEboGYb6L8brfGmERW53w6GUFqM+LPzITG7fLbfbY gh0Adl3wUrwpMM3GO+cjvoecwj69xToPqcAZY8iFvCLqJ2cLnWjFJbw2na1ytoMXu1JbFstGbWy kRQH2WcHey0D/y9sR1oDkImcf+vYEtXIW8EVDE1d0xv2ERRGiKa0jd0o/WR72amrGLw== X-Gm-Gg: ATEYQzz0WNQETd11RO9siA0iN4fg+OdQHRT3p1dLTy3v82VI9VLy9KTwr4zFPJ80Rey AUpbXiQtMGTALNJZ7fthZAaewzaEnuPUtJeMoji8ZaOu3DTG2TWCssGjSUMDSIyGbkwOH6fXXJ7 thdvJTeOFIGygTk4mjg2OSFkfLQl50NooYyGkpDj+F5T7N2QO3J7Fx9SSvgntiYwWd5hLGXBxMY N7N9TMuQM5bOh96Qv9hIT/+js2VXJ+P38OMziz214+IKvPS2sf8w218HK2eRtDZMF64At/4RFFi LSWkrBsaMxlLuoaFQRHnhaexmoafT2Lb4EwLDLdQNiyNPYoXLFStbQVYU1DFvltRLrLdTZy551F MtwUWcUwE6+N9Gs1IhjvYFeScIr7/uHKzMKy8M57v2L4hMjL8C+rNW6EcyAnXGu5EtgChVaOFir fcFsL7 X-Received: by 2002:a05:600c:4e0f:b0:483:badb:6191 with SMTP id 5b1f17b1804b1-483c3db0103mr18741845e9.8.1772092708566; Wed, 25 Feb 2026 23:58:28 -0800 (PST) X-Received: by 2002:a05:600c:4e0f:b0:483:badb:6191 with SMTP id 5b1f17b1804b1-483c3db0103mr18741605e9.8.1772092708169; Wed, 25 Feb 2026 23:58:28 -0800 (PST) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483bd750607sm127604395e9.10.2026.02.25.23.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 23:58:27 -0800 (PST) From: Javier Martinez Canillas To: Francesco Lavra , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/solomon: Fix page start when updating rectangle in page addressing mode In-Reply-To: <20260210180932.736502-1-flavra@baylibre.com> References: <20260210180932.736502-1-flavra@baylibre.com> Date: Thu, 26 Feb 2026 08:58:25 +0100 Message-ID: <87tsv4ueam.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Francesco Lavra writes: Hello Francesco, Thanks for the patch! > In page addressing mode, the pixel values of a dirty rectangle must be sent > to the display controller one page at a time. The range of pages > corresponding to a given rectangle is being incorrectly calculated as if > the Y value of the top left coordinate of the rectangle was 0. This can > result in rectangle updates being displayed on wrong parts of the screen. > > Fix the above issue by consolidating the start page calculation in a single > place at the beginning of the update_rect function, and using the > calculated value for all addressing modes. > > Fixes: b0daaa5cfaa5 ("drm/ssd130x: Support page addressing mode") > Signed-off-by: Francesco Lavra > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat