Re: [PATCH] ASoC: stm32: sai: manage context in set_sysclk callback

[Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>]

Hi Olivier

> > Or maybe reset simple_dai->sysclk somehow (not sure...) ?
> > (simple_init_dai() will call snd_soc_dai_set_sysclk() if it has
> > simple_dai->sysclk)
> > 
> 
> Yes, resetting simple_dai->sysclk may also be an option, but I could not 
> find a way to do it in practice. Requesting a reset of 
> simple_dai->sysclk from the CPU DAI .probe callback might be the right 
> time I think, but there is no service that allows this.
> Another way would be to set "system-clock-frequency = <0>" in the CPU DT 
> node. However, this is not possible, as it conflicts with the following 
> check in the simple_set_clk_rate() function:
> if (simple_dai->clk_fixed && rate != simple_dai->sysclk) {
>     dev_err(...)
> }

OK, thank you for confirming the situation.

Generalize closk setting is one of complex code, and some driver might get
damage if framework was updated, like you.

> So, the current patch still seems like the better option to me.

Yeah, it seems.


Thank you for your help !!

Best regards
---
Kuninori Morimoto