From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF14E92FF8 for ; Fri, 6 Oct 2023 08:51:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231247AbjJFIvE (ORCPT ); Fri, 6 Oct 2023 04:51:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230434AbjJFIvB (ORCPT ); Fri, 6 Oct 2023 04:51:01 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D778393 for ; Fri, 6 Oct 2023 01:51:00 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5354C21866; Fri, 6 Oct 2023 08:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1696582259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lrPVGs9PEDT/K6IOorzhQy/e4LFHokzpzNfy48DoQ1A=; b=NkCtdR3+ZzpvrTElBT0GbSq52+J3kim3CcY1njUTx8njN44RrETFaRTSkKfECLBxFBkhFQ jjgk+sD08j3AIjkW0rkLbHQVBxTQHlv7Y4FTOcljaFHcL/Z/n7Zr10x6KEbCliPuqZrC6t hBmn5RWYI0hVeJn1ZOyUv0IIMZZjR9M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1696582259; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lrPVGs9PEDT/K6IOorzhQy/e4LFHokzpzNfy48DoQ1A=; b=c6GSbyzE9wz5ZlvF84cfbAiDqZhrid7HsujzNW2gwhy4JSE+YoQ8YXXGbDNaPTQECW696v KhfgAPURWj4xdcDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 15B1313A2E; Fri, 6 Oct 2023 08:50:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LztfBHPKH2UKIwAAMHmgww (envelope-from ); Fri, 06 Oct 2023 08:50:59 +0000 Date: Fri, 06 Oct 2023 10:50:58 +0200 Message-ID: <87ttr4w2vh.wl-tiwai@suse.de> From: Takashi Iwai To: Thomas Perl Cc: Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , "trivial@kernel.org" Subject: Re: [PATCH] sound: fix name of SIS7013 sound chip in comment In-Reply-To: <5E4B5CA1-1109-4C82-A581-838ACF19A15D@thp.io> References: <5E4B5CA1-1109-4C82-A581-838ACF19A15D@thp.io> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Sep 2023 09:17:32 +0200, Thomas Perl wrote: > > While grep'ing for SIS7012, I noticed that there is > only one reference to it in sound/pci/intel8x0m.c, > while most of its code lives in sound/pci/intel8x0.c. > > This probably was a simple copy'n'paste mistake, as > the sound/pci/intel8x0m.c driver implements support > for SIS7013 (see DEVICE_SIS), and the two devices > seem to share the same behavior / registers. > > Signed-off-by: Thomas Perl Thanks for the patch. Unfortunately the patch isn't applicable cleanly, likely due to your mailer malformed the spaces. As it's a really trivial change, I fixed manually now. But, at the next time, please try to fix your mailer setup and at best test the patch application by yourself beforehand. Takashi > --- > sound/pci/intel8x0m.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/intel8x0m.c b/sound/pci/intel8x0m.c > index 2845cc006d0c..653ecca78238 100644 > --- a/sound/pci/intel8x0m.c > +++ b/sound/pci/intel8x0m.c > @@ -918,7 +918,7 @@ static int snd_intel8x0m_ich_chip_init(struct intel8x0m *chip, int probing) > } > if (chip->device_type == DEVICE_SIS) { > - /* unmute the output on SIS7012 */ > + /* unmute the output on SIS7013 */ > iputword(chip, 0x4c, igetword(chip, 0x4c) | 1); > } > -- 2.39.2 >