From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB6CC83F2E for ; Thu, 31 Aug 2023 16:18:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346768AbjHaQSi (ORCPT ); Thu, 31 Aug 2023 12:18:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239540AbjHaQSh (ORCPT ); Thu, 31 Aug 2023 12:18:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7D0CB0; Thu, 31 Aug 2023 09:18:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 62E9AB82324; Thu, 31 Aug 2023 16:18:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE41BC433C8; Thu, 31 Aug 2023 16:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693498708; bh=8mihFSvYYGejx9N0MfZQyqwmoRIFUqz4THpIXBeJ4gQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=cm+dXHMYOMpdB+oqp24HHZI0Q743h4HkYXXgCxcV4b0Mq7lVAiVowaIp7S1asTz1Y 3HAfbYzQAlgq27ijXObLqIDuufPNgVD2Wcfdp1ges0xBS+e5vW0AciQQmx864OJuqY k5rM7816ErCmqGgU4MdL/awjMDZ8O/xIpAnOmSV7euW0XpczSKxgeru0rkAKyVgdRW P+xKYKL64qdrNt08/R3Mpq1imNqpZ1FtaQmWFokjCFP2FhNiLF1fdC4J8Fy1Q8NIbX +XG0puuzhWK7Eqi8tS3qrRScgUk2YxOx6lO4rDK/k2myORRkNsoLPlb3kz6uMlBysX LsXxV9ZGH8C2g== From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= To: Daniel Borkmann , Andrii Nakryiko , Mykola Lysenko , bpf@vger.kernel.org Cc: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Alexei Starovoitov , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next] selftests/bpf: Include build flavors for install target In-Reply-To: References: <20230828183329.546959-1-bjorn@kernel.org> Date: Thu, 31 Aug 2023 18:18:25 +0200 Message-ID: <87ttsf18z2.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Borkmann writes: > On 8/28/23 8:33 PM, Bj=C3=B6rn T=C3=B6pel wrote: >> From: Bj=C3=B6rn T=C3=B6pel >>=20 >> When using the "install" or targets depending on install, >> e.g. "gen_tar", the BPF machine flavors weren't included. >>=20 >> A command like: >> | make ARCH=3Driscv CROSS_COMPILE=3Driscv64-linux-gnu- O=3D/workspace= /kbuild \ >> | HOSTCC=3Dgcc FORMAT=3D SKIP_TARGETS=3D"arm64 ia64 powerpc sparc6= 4 x86 sgx" \ >> | -C tools/testing/selftests gen_tar >> would not include bpf/no_alu32, bpf/cpuv4, or bpf/bpf-gcc. >>=20 >> Include the BPF machine flavors for "install" make target. >>=20 >> Signed-off-by: Bj=C3=B6rn T=C3=B6pel > > Looks good and BPF CI also seems to be fine with it, wrt INSTDIRS could w= e use > a more appropriate location where we define it? Was thinking sth like: > > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftes= ts/bpf/Makefile > index 7c77a21c3371..8b724efb8b7f 100644 > --- a/tools/testing/selftests/bpf/Makefile > +++ b/tools/testing/selftests/bpf/Makefile > @@ -50,14 +50,17 @@ TEST_GEN_PROGS =3D test_verifier test_tag test_maps t= est_lru_map test_lpm_map test > test_cgroup_storage \ > test_tcpnotify_user test_sysctl \ > test_progs-no_alu32 > +TEST_INST_SUBDIRS :=3D no_alu32 > > # Also test bpf-gcc, if present > ifneq ($(BPF_GCC),) > TEST_GEN_PROGS +=3D test_progs-bpf_gcc > +TEST_INST_SUBDIRS +=3D bpf_gcc > endif > > ifneq ($(CLANG_CPUV4),) > TEST_GEN_PROGS +=3D test_progs-cpuv4 > +TEST_INST_SUBDIRS +=3D cpuv4 > endif > > [...] Ok! I'll spin a v2!