From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Hector Martin <marcan@marcan.st>
Cc: povik+lin@cutebit.org, sven@svenpeter.dev, alyssa@rosenzweig.io,
devicetree@vger.kernel.org, asahi@lists.linux.dev,
linux-kernel@vger.kernel.org, marcan@marcan.st
Subject: Re: [PATCH] arm64: dts: apple: Rename dart-sio* to sio-dart*
Date: Mon, 05 Dec 2022 17:26:16 +0100 [thread overview]
Message-ID: <87tu293jh3.fsf@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20221205100211.3155-1-marcan@marcan.st> (message from Hector Martin on Mon, 5 Dec 2022 19:02:11 +0900)
> From: Hector Martin <marcan@marcan.st>
> Date: Mon, 5 Dec 2022 19:02:11 +0900
>
> All the other DARTs are named foo-dart, so let's keep things consistent.
>
> Fixes: 51979fbb7fb8 ("arm64: dts: apple: t600x: Add MCA and its support")
> Fixes: 8a3df85ad87d ("arm64: dts: apple: t8103: Add MCA and its support")
> Signed-off-by: Hector Martin <marcan@marcan.st>
Consistency is good!
Reviewed-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> arch/arm64/boot/dts/apple/t600x-die0.dtsi | 6 +++---
> arch/arm64/boot/dts/apple/t8103.dtsi | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/apple/t600x-die0.dtsi b/arch/arm64/boot/dts/apple/t600x-die0.dtsi
> index 0b8958a8db77..e2f972c2c147 100644
> --- a/arch/arm64/boot/dts/apple/t600x-die0.dtsi
> +++ b/arch/arm64/boot/dts/apple/t600x-die0.dtsi
> @@ -53,7 +53,7 @@ wdt: watchdog@2922b0000 {
> interrupts = <AIC_IRQ 0 631 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> - dart_sio_0: iommu@39b004000 {
> + sio_dart_0: iommu@39b004000 {
> compatible = "apple,t6000-dart";
> reg = <0x3 0x9b004000 0x0 0x4000>;
> interrupt-parent = <&aic>;
> @@ -62,7 +62,7 @@ dart_sio_0: iommu@39b004000 {
> power-domains = <&ps_sio_cpu>;
> };
>
> - dart_sio_1: iommu@39b008000 {
> + sio_dart_1: iommu@39b008000 {
> compatible = "apple,t6000-dart";
> reg = <0x3 0x9b008000 0x0 0x8000>;
> interrupt-parent = <&aic>;
> @@ -179,7 +179,7 @@ admac: dma-controller@39b400000 {
> <&aic AIC_IRQ 0 1118 IRQ_TYPE_LEVEL_HIGH>,
> <0>,
> <0>;
> - iommus = <&dart_sio_0 2>, <&dart_sio_1 2>;
> + iommus = <&sio_dart_0 2>, <&sio_dart_1 2>;
> power-domains = <&ps_sio_adma>;
> resets = <&ps_audio_p>;
> };
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi
> index 6f5a2334e5b1..1ea760ef2c25 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -318,7 +318,7 @@ cpufreq_p: performance-controller@211e20000 {
> #performance-domain-cells = <0>;
> };
>
> - dart_sio: iommu@235004000 {
> + sio_dart: iommu@235004000 {
> compatible = "apple,t8103-dart";
> reg = <0x2 0x35004000 0x0 0x4000>;
> interrupt-parent = <&aic>;
> @@ -431,7 +431,7 @@ admac: dma-controller@238200000 {
> <0>,
> <0>;
> #dma-cells = <1>;
> - iommus = <&dart_sio 2>;
> + iommus = <&sio_dart 2>;
> power-domains = <&ps_sio_adma>;
> resets = <&ps_audio_p>;
> };
> --
> 2.35.1
>
>
>
prev parent reply other threads:[~2022-12-05 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 10:02 Hector Martin
2022-12-05 16:14 ` Sven Peter
2022-12-05 16:26 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu293jh3.fsf@bloch.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=povik+lin@cutebit.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®