From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFF0C388F9 for ; Sun, 8 Nov 2020 11:22:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CC8A206ED for ; Sun, 8 Nov 2020 11:22:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="JQ/qlHhT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728350AbgKHLWA (ORCPT ); Sun, 8 Nov 2020 06:22:00 -0500 Received: from z5.mailgun.us ([104.130.96.5]:64258 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgKHLV7 (ORCPT ); Sun, 8 Nov 2020 06:21:59 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604834518; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=+a2nw8TOnWhGkjW2VdGmo04dSuvzksPHyNngfg5RaIM=; b=JQ/qlHhTmHZgSbG8xLCelkG1PR1uc3pJ/6+TLeWKtgURdL487l7Ea17OWkvAybjKvifYviqa jqO1tGClEisrMl9kI77nLWmc2KvKMleGvhp0cFHs4qG2WBr3skDGhh5pqlvMzQ5GOufduvfN 25gk+wTFviJi7C1beJOhKaWYOZw= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5fa7d4be9d6b206d94f27083 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 08 Nov 2020 11:21:34 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BCCD7C43385; Sun, 8 Nov 2020 11:21:33 +0000 (UTC) Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 44852C433C8; Sun, 8 Nov 2020 11:21:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 44852C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Jakub Kicinski Cc: Arnd Bergmann , netdev@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, bridge@lists.linux-foundation.org, linux-hams@vger.kernel.org, Christoph Hellwig , Alexander Viro , Johannes Berg , Andrew Lunn , Heiner Kallweit Subject: Re: [RFC net-next 00/28] ndo_ioctl rework References: <20201106221743.3271965-1-arnd@kernel.org> <20201107160612.2909063a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Date: Sun, 08 Nov 2020 13:21:24 +0200 In-Reply-To: <20201107160612.2909063a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (Jakub Kicinski's message of "Sat, 7 Nov 2020 16:06:12 -0800") Message-ID: <87tuu05c23.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jakub Kicinski writes: >> For the wireless drivers, removing the old drivers >> instead of just the dead code might be an alternative, depending >> on whether anyone thinks there might still be users. > > Dunno if you want to dig into removal with a series like this, > anything using ioctls will be pretty old (with the exception > of what you separated into ndo_eth_ioctl). You may get bogged > down. I would very much like to get rid of unused ancient wireless drivers but the problem is that it's next to impossible to know if someone still uses a driver, or if the driver is even working. For example, few months back I suggested removing one driver which I thought to be completely unused (forgot already the name of the driver) and to my big surprise there was still a user, and he reported it working with a recent kernel release. So I don't know what to do. Should we try adding a warning like below? :) "This ancient driver will be removed from the kernel in 2022, but if it still works send report to <...@...> to avoid the removal." How do other subsystems handle ancient drivers? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches