From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC95C43467 for ; Thu, 8 Oct 2020 23:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C04E12224C for ; Thu, 8 Oct 2020 23:27:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Swp8IJ+D"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="p20GZo4A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731005AbgJHX1J (ORCPT ); Thu, 8 Oct 2020 19:27:09 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:53588 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725969AbgJHX1J (ORCPT ); Thu, 8 Oct 2020 19:27:09 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1602199626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mCF0g/+MND1nwyGx+3yFFM5NagyeBqr5yClJxHT9QEA=; b=Swp8IJ+Dgcfzc0AiaM09Ka+XguUbPbdks8xUopa30a0QG9VTUz1p8OEM/pGJUj68R66uKo 3BNSmfCEhBPwkb8gb5JL4X55GCeGTMuIK1C1gxHhGqSuscAuXf8wAkIfOwuc+l67uhL3Xe BqUhMtEBt3gBjhNjB+VlWJuFDj9QSipDsfeTtxaYo7SEDz1Go6f4eLWBGNVolW/TsKzcAx ydm1GNGRt4oEliwJTKULEbyOwkKClOsukVdfspauVbOvwTZbIA9O7efNhcV6ZK2tGqNIwt MftjjoJYadRztuHmP53tOwnPCc2E7z5TtmehSD/jmszTLaRQy/YjrMb2cJsBnQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1602199626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mCF0g/+MND1nwyGx+3yFFM5NagyeBqr5yClJxHT9QEA=; b=p20GZo4A08k/MQ9YpJFZ8xL4ZpcN/OzaBgyB0Z6JYGu3goDxY7suWz1HdpJ6zXE5AO7QvB KZHAotM6g3c4ycCw== To: David Woodhouse , x86@kernel.org Cc: kvm , Paolo Bonzini , linux-kernel Subject: Re: [PATCH 5/5] x86/kvm: Add KVM_FEATURE_MSI_EXT_DEST_ID In-Reply-To: References: <803bb6b2212e65c568c84ff6882c2aa8a0ee03d5.camel@infradead.org> <20201007122046.1113577-1-dwmw2@infradead.org> <20201007122046.1113577-5-dwmw2@infradead.org> <87blhcx6qz.fsf@nanos.tec.linutronix.de> <95625dfce360756b99641c31212634c1bf80a69a.camel@infradead.org> <87362owhcb.fsf@nanos.tec.linutronix.de> Date: Fri, 09 Oct 2020 01:27:06 +0200 Message-ID: <87tuv4uwmt.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08 2020 at 22:39, David Woodhouse wrote: > On Thu, 2020-10-08 at 23:14 +0200, Thomas Gleixner wrote: >> > >> > (We'd want the x86_vector_domain to actually have an MSI compose >> > function in the !CONFIG_PCI_MSI case if we did this, of course.) >> >> The compose function and the vector domain wrapper can simply move to >> vector.c > > I ended up putting __irq_msi_compose_msg() into apic.c and that way I > can make virt_ext_dest_id static in that file. > > And then I can move all the HPET-MSI support into hpet.c too. Works for me. > https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/ext_dest_id For the next submission, can you please - pick up the -ENODEV changes for HPET/IOAPIC which I posted earlier - shuffle all that compose/IOAPIC cleanup around before adding that extended dest id stuff. Thanks, tglx