From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD7EC11D25 for ; Fri, 21 Feb 2020 00:30:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C7C4206DB for ; Fri, 21 Feb 2020 00:30:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729461AbgBUAaI (ORCPT ); Thu, 20 Feb 2020 19:30:08 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:48561 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729365AbgBUAaI (ORCPT ); Thu, 20 Feb 2020 19:30:08 -0500 Date: 21 Feb 2020 09:30:04 +0900 X-IronPort-AV: E=Sophos;i="5.70,466,1574089200"; d="scan'208";a="39642237" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 21 Feb 2020 09:30:04 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id 3F324400C0A8; Fri, 21 Feb 2020 09:30:04 +0900 (JST) Message-ID: <87tv3ksryd.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Rob Herring Cc: Liam Girdwood , Mark Brown , Mark Rutland , Linux-ALSA , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] ASoC: dt-bindings: renesas,rsnd: switch to yaml base Documentation In-Reply-To: References: <87d0ahzr9d.wl-kuninori.morimoto.gx@renesas.com> <20200219161732.GB25095@bogus> <874kvmt355.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob Thank you for your feedback > > This needs clock array. Like this > > > > clock-frequency = <12288000 11289600>; > > Sorry, but the type is already defined in the spec. You'll still get > warnings from the common schema and you can't override that here. > > Not sure what to suggest. Leave it with a fixme or move to > assigned-clocks-rates instead? As you know, I'm not familiar with yaml base Documentation :/ I want leave it as your fixme if possible. > > > > + # For multi OF-graph > > > > + ports: > > > > + description: multi OF-Graph subnode > > > > + type: object > > > > + patternProperties: > > > > + "port(@.*)?": (snip) > > > > + $ref: "#properties/port" > > > > > > Would be more simple to just always have 'ports'. > > > > Having "ports" or "port" are case-by-case, not always. > > Why? > > This: > > port {}; > > and this: > > ports { > port {}; > }; > > Are treated the same. It's perfectly valid to have 'ports' with a single port. Yeah, if it needs only 1 port. If I'm not misunderstanding, We are using it as ports { port@0 { endpoint {} }; port@1 { endpoint {} }; .... }; or simply port { endpoint {} }; And here, sometimes, "port" and "endpoint" both need "reg". Thank you for your help !! Best regards --- Kuninori Morimoto