From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933063AbeAOKpN (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Mon, 15 Jan 2018 05:45:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51566 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755339AbeAOKpI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 Jan 2018 05:45:08 -0500
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Stephen Hemminger <sthemmin@microsoft.com>, kvm@vger.kernel.org,
        Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Haiyang Zhang <haiyangz@microsoft.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
        "Michael Kelley \(EOSG\)" <Michael.H.Kelley@microsoft.com>,
        Ingo Molnar <mingo@redhat.com>,
        Roman Kagan <rkagan@virtuozzo.com>,
        Andy Lutomirski <luto@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Mohammed Gamal <mmorsy@redhat.com>
Subject: Re: [PATCH v2 2/7] x86/hyper-v: add a function to read both TSC and TSC page value simulateneously
References: <20171213150945.24054-1-vkuznets@redhat.com>
        <20171213150945.24054-3-vkuznets@redhat.com>
        <alpine.DEB.2.20.1801142134370.2371@nanos>
Date: Mon, 15 Jan 2018 11:45:01 +0100
In-Reply-To: <alpine.DEB.2.20.1801142134370.2371@nanos> (Thomas Gleixner's
        message of "Sun, 14 Jan 2018 21:35:27 +0100 (CET)")
Message-ID: <87tvvnieoi.fsf@vitty.brq.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 15 Jan 2018 10:45:08 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>

Thomas Gleixner <tglx@linutronix.de> writes:

> On Wed, 13 Dec 2017, Vitaly Kuznetsov wrote:
>
>> This is going to be used from KVM code where we need to get both
>> TSC and TSC page value.
>> 
>> When Hyper-V code is compiled out just return rdtsc(), this will allow us
>> to avoid ugly ifdefs in non-Hyper-V code.
>
> That's not what the patch implements....
>

Not anymore, thanks, will fix the description.

>> +static inline u64 hv_read_tsc_page_tsc(const struct ms_hyperv_tsc_page *tsc_pg,
>> +				       u64 *cur_tsc)
>> +{
>> +	BUG();
>> +	return U64_MAX;
>> +}

-- 
  Vitaly