From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752025AbdLAKNl (ORCPT ); Fri, 1 Dec 2017 05:13:41 -0500 Received: from ozlabs.org ([103.22.144.67]:43117 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751645AbdLAKNj (ORCPT ); Fri, 1 Dec 2017 05:13:39 -0500 From: Michael Ellerman To: Jiri Kosina , Miroslav Benes Cc: jpoimboe@redhat.com, jeyu@kernel.org, pmladek@suse.com, lpechacek@suse.cz, pavel@ucw.cz, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Oleg Nesterov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski , linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [PATCH v4 1/2] livepatch: send a fake signal to all blocking tasks In-Reply-To: References: <20171115135014.20594-1-mbenes@suse.cz> <20171115135014.20594-2-mbenes@suse.cz> Date: Fri, 01 Dec 2017 21:13:36 +1100 Message-ID: <87tvxabvsf.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri Kosina writes: > On Wed, 15 Nov 2017, Miroslav Benes wrote: >> Live patching consistency model is of LEAVE_PATCHED_SET and >> SWITCH_THREAD. This means that all tasks in the system have to be marked >> one by one as safe to call a new patched function. Safe means when a >> task is not (sleeping) in a set of patched functions. That is, no >> patched function is on the task's stack. Another clearly safe place is >> the boundary between kernel and userspace. The patching waits for all >> tasks to get outside of the patched set or to cross the boundary. The >> transition is completed afterwards. ... >> >> Signed-off-by: Miroslav Benes >> Cc: Oleg Nesterov >> Cc: Michael Ellerman >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: "H. Peter Anvin" >> Cc: Andy Lutomirski >> Cc: linuxppc-dev@lists.ozlabs.org >> Cc: x86@kernel.org >> --- >> Documentation/ABI/testing/sysfs-kernel-livepatch | 12 +++++++ >> Documentation/livepatch/livepatch.txt | 11 +++++-- >> arch/powerpc/kernel/signal.c | 6 ++-- >> arch/x86/entry/common.c | 6 ++-- >> kernel/livepatch/core.c | 30 +++++++++++++++++ >> kernel/livepatch/transition.c | 41 ++++++++++++++++++++++++ >> kernel/livepatch/transition.h | 1 + >> kernel/signal.c | 4 ++- > > I'd like to be queuing this patchset for the next merge window, so if > there are any objections for the out-of-kernel/livepatch/* changes, please > speak up now. The powerpc changes look innocuous and in-line with the change log, no objection from me. Have an ack if you like: Acked-by: Michael Ellerman (powerpc) cheers