From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754901AbdJISaS (ORCPT ); Mon, 9 Oct 2017 14:30:18 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:16819 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754207AbdJISaQ (ORCPT ); Mon, 9 Oct 2017 14:30:16 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 09 Oct 2017 20:30:15 +0200 X-ME-IP: 90.55.206.157 From: Robert Jarzmik To: Daniel Thompson , Andrea Adami Cc: Lee Jones , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] backlight: tdo24m: fix the spi cs between transfers References: <20171006195826.27500-1-robert.jarzmik@free.fr> <0ee32bde-0f3b-52b2-965f-84fa017c7b16@linaro.org> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 09 Oct 2017 20:30:13 +0200 In-Reply-To: <0ee32bde-0f3b-52b2-965f-84fa017c7b16@linaro.org> (Daniel Thompson's message of "Mon, 9 Oct 2017 12:14:38 +0100") Message-ID: <87tvz8dvii.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Thompson writes: > On 06/10/17 20:58, Robert Jarzmik wrote: > > I'm a tiny bit worried about see-saw bug fixing here but nevertheless this > change looks correct to me. > > Mike's change was eight years ago and it is reasonable to hope that the patch > was really just working around a (hopefully long fixed) bug in the SPI driver! Actually I think it's the case. And the driver bug fix is here : a52db659c79c ("spi: pxa2xx: Fix cs_change management") And please don't apply this as there are 2 other LCDs which are affected by the same issue and reported by Andrea, for which I had not correlated the issue until yesterday, so I'll have to respin this 2 others files, namely : - drivers/video/backlight/corgi_lcd.c. - drivers/video/backlight/tosa_lcd.c. There 2 other candidates I won't touch as they are not under my maintainance, and I have no way to test them : - ili922x.c - ltv350qv.c > Acked-by: Daniel Thompson Thanks, but there will be a v2 with exactly the same fix in 3 files. Cheers. -- Robert