From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755462AbdEHTEG (ORCPT ); Mon, 8 May 2017 15:04:06 -0400 Received: from anholt.net ([50.246.234.109]:57314 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbdEHTEE (ORCPT ); Mon, 8 May 2017 15:04:04 -0400 From: Eric Anholt To: Florian Fainelli , dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, Ray Jui , Scott Branden , Jon Mason Cc: linux-kernel@vger.kernel.org, mircea.carausu@broadcom.com Subject: Re: [PATCH] drm/vc4: Enable selection in Kconfig on any BCM platform. In-Reply-To: <30064246-3ad9-da6b-8035-804fe56d6efe@gmail.com> References: <20170508181825.19854-1-eric@anholt.net> <30064246-3ad9-da6b-8035-804fe56d6efe@gmail.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 08 May 2017 12:03:59 -0700 Message-ID: <87tw4vf9wg.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Florian Fainelli writes: > On 05/08/2017 11:18 AM, Eric Anholt wrote: >> With the Cygnus port, we needed to add at least "|| ARCH_BCM_CYGNUS" >> to let the module get built on a cygnus-only kernel. However, I >> anticipate having a port for Kona soon, so just present the module on >> all of BCM. > > This seems reasonable, but by replacing ARCH_BCM2835 which is common to > ARM/Linux and ARM64/Linux, you are no longer allowing an ARM64 systems > to benefit from this driver unless COMPILE_TEST is also selected, right? > > This could be: > > depends on COMPILE_TEST > depends on ARCH_BCM # 32-bit ARM > depends on ARCH_BCM2835 || ARCH_BCM_IPROC # 64-bit ARM > > or maybe down to just: > > depends on COMPILE_TEST > > and let DRM, COMMON_CLK and SND drive the bulk of the dependencies? That would disable it on ARCH_BCM2835 && !COMPILE_TEST, right? COMPILE_TEST is typically disabled. I think I should use ARCH_BCM2835 || ARCH_BCM || COMPILE_TEST. Does that sound good? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlkQwSAACgkQtdYpNtH8 nuhBNg//SxkeyB5/HUy9KGRcxFKNn4UyXJd+QcPa6gkT/WftI6w3yp0jn3X8GdMD 5bbXd3w7oeJjoeJUD9QWJOlmGQalDJEDDTmpz4JiNo6+FzYIo0F2uQpKxZBSsRR9 jz0/3YYyJMm4raN9uVuLznyBVv9NpRGTL8Ir2FtZd9u4dkdGDcMDiH2WFmIaF9PJ A+SQK/osqJLWoG5gQ7FIDCK4qRUHirXMZ4pvm5Ax2bTYLgcWtNkt9MqP4rjWsLMF Dl896T9C1ytQXIqirSIYHoTuLe3Zmc790qGLjEa/ycfrt1TGvRme6hgBqJc+ZqSU pIOrJucKr8oERiBSlD2E5eTqsB6o5UQ9g40eZLdrr+o00V8YzwC+UPfNRZMEp/WQ HGIJawhqYGS8D+6GQqJwsuEOMMUGoY17ob1UsdTY2pD6DYOzwB2EDK5RK1tLx5Lj 459AQ5tins7v9bouZLvevps6uMxKXuJej000mN/fUELaqSpwBInup4Y80icdEEui +Vbetoz6/arQs5SR0wCt+P0W95VjHnmiiAqCEOJfQBgIbPOAo8GpfNeSbBgyGkbk j7wIAOYqqIAjGXGsj9aa/fbBwjRMTvIk/vMC4OSRYnSxlmFVgoIgmaKkOTZds0QP Aamk4xSIIrjhTvdziw14Nwhi7YU0gPtPKF/WtNbn/UcFkakll9A= =GcNj -----END PGP SIGNATURE----- --=-=-=--