From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933483AbcI2S2W (ORCPT ); Thu, 29 Sep 2016 14:28:22 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38352 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755404AbcI2S2L (ORCPT ); Thu, 29 Sep 2016 14:28:11 -0400 From: Gabriel Krisman Bertazi To: Christoph Hellwig Cc: hans.verkuil@cisco.com, brking@us.ibm.com, haver@linux.vnet.ibm.com, ching2048@areca.com.tw, axboe@fb.com, alex.williamson@redhat.com, kvm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] genwqe: use pci_irq_allocate_vectors Organization: IBM References: <1473600688-24043-1-git-send-email-hch@lst.de> <1473600688-24043-6-git-send-email-hch@lst.de> Date: Thu, 29 Sep 2016 15:28:02 -0300 In-Reply-To: <1473600688-24043-6-git-send-email-hch@lst.de> (Christoph Hellwig's message of "Sun, 11 Sep 2016 15:31:27 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16092918-0032-0000-0000-00000293E303 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16092918-0033-0000-0000-00000F05DF4B Message-Id: <87twcyk1cd.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-29_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609290319 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig writes: > Simply the interrupt setup by using the new PCI layer helpers. Good clean up. Tested and: Acked-by: Gabriel Krisman Bertazi > One odd thing about this driver is that it looks like it could request > multiple MSI vectors, but it will then only ever use a single one. I'll take a look at this. -- Gabriel Krisman Bertazi