From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754257AbcIBRm5 (ORCPT ); Fri, 2 Sep 2016 13:42:57 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:45584 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbcIBRmz (ORCPT ); Fri, 2 Sep 2016 13:42:55 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: make global2 code optional In-Reply-To: <20160902171920.GP16864@lunn.ch> References: <20160902120819.10773-1-vivien.didelot@savoirfairelinux.com> <20160902120819.10773-4-vivien.didelot@savoirfairelinux.com> <20160902145511.GH16864@lunn.ch> <87k2eugwcs.fsf@ketchup.mtl.sfl> <20160902161148.GK16864@lunn.ch> <87vayens26.fsf@ketchup.mtl.sfl> <20160902171920.GP16864@lunn.ch> User-Agent: Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) Date: Fri, 02 Sep 2016 13:32:11 -0400 Message-ID: <87twdyi4x0.fsf@ketchup.mtl.sfl> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, Andrew Lunn writes: >> I agree. Does the following snippet looks OK? >> >> >> #ifndef CONFIG_NET_DSA_MV88E6XXX_GLOBAL2 >> if (mv88e6xxx_has(chip, MV88E6XXX_FLAG_GLOBAL2)) { >> dev_err(chip->dev, "Missing support for Global 2 registers\n"); > > I would include the name of the option which needs enabling. Also it > is not really missing. It has not been enabled. > > "The required compile time options needed to support this switch have > not been enabled. Please enable: CONFIG_NET_DSA_MV88E6XXX_GLOBAL2" That is much better indeed, respining. Thanks! Vivien