From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: "Vick\, Matthew" <matthew.vick@intel.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>, "Kirsher\,
Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"e1000-devel\@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ethernet: fm10k: Actually drop 4 bits
Date: Sat, 24 Jan 2015 01:50:06 +0100 [thread overview]
Message-ID: <87twzhknnl.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <D0E81E0C.682EB%matthew.vick@intel.com> (Matthew Vick's message of "Sat, 24 Jan 2015 00:18:59 +0000")
On Sat, Jan 24 2015, "Vick, Matthew" <matthew.vick@intel.com> wrote:
> Good catch! I noticed this too and was getting a patch together to address
> this.
>
> The difference is that I was planning on not silently accepting an invalid
> VLAN ID to begin with and returning FM10K_ERR_PARAM if the VLAN was
> invalid, which I think is a better approach for this situation. If it's
> alright with you, I'll generate the patch shortly and credit you via your
> Reported-by.
Sure, do what you think is best.
Rasmus
next prev parent reply other threads:[~2015-01-24 0:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 22:53 Rasmus Villemoes
2015-01-23 3:27 ` Jeff Kirsher
2015-01-24 0:18 ` Vick, Matthew
2015-01-24 0:50 ` Rasmus Villemoes [this message]
2015-01-26 16:58 ` Vick, Matthew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twzhknnl.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=alexander.h.duyck@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®