mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Minchan Kim <minchan@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [RFC/PATCH] perf tools: Check recorded kernel version when finding vmlinux
Date: Wed, 30 Jul 2014 08:38:14 +0900	[thread overview]
Message-ID: <87tx5zhh21.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <53D7BA6E.9040002@gmail.com> (David Ahern's message of "Tue, 29 Jul 2014 09:14:54 -0600")

Hi David,

On Tue, 29 Jul 2014 09:14:54 -0600, David Ahern wrote:
> On 7/29/14, 2:15 AM, Namhyung Kim wrote:
>> This requires to change signature of symbol__init() to receive struct
>> perf_session_env *.  This patch only does some trivial changes - some
>
> Why only pass the env for perf-report? Why not for any command
> analyzing a file? So for live commands env is NULL meaning use host
> paths; for recorded files pass env from session header and use it
> (plus symbol settings like symfs).

Yes, it needs other changes like you said.  But I'd like to hear from
your opinions on the problem and proposed fix before going further.

My other concern is that why it isn't covered by a build-id cache.

Thanks,
Namhyung

      reply	other threads:[~2014-07-29 23:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29  8:15 Namhyung Kim
2014-07-29 15:14 ` David Ahern
2014-07-29 23:38   ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx5zhh21.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®