From: arno@natisbad.org (Arnaud Ebalard)
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <khali@linux-fr.org>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon: add support for GMT G751 chip in lm75 driver
Date: Sat, 09 Nov 2013 20:42:05 +0100 [thread overview]
Message-ID: <87txflfjle.fsf@natisbad.org> (raw)
In-Reply-To: <20131109182707.GA19407@roeck-us.net>
Hi Guenter,
Guenter Roeck <linux@roeck-us.net> writes:
> On Sat, Nov 09, 2013 at 06:39:14PM +0100, Arnaud Ebalard wrote:
>>
>> This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP
>> based board, via DT).
>>
>> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
>
> Looks good. I'll apply it to my -next branch. Since I already sent my
> pull request to Linus, this will only go in after -rc1, which I hope
> should be ok (unless Jean wants to pick it up for his pull request).
Perfect, thanks.
>> ---
>> Hi Guenter,
>>
>> As a side note, I removed the hunk that was present in previous patch to
>> add gmt to the list of DT vendor prefixes because I noticed someone had
>> taken care: https://lkml.org/lkml/2013/9/12/365
>>
>> For the records, here is what I get on my NAS with the attached patch:
>>
>> root@thin:/sys# sensors
>> g762-i2c-0-3e
>> Adapter: mv64xxx_i2c adapter
>> fan1: 5461 RPM (div = 1)
>>
>> g762-i2c-0-48
>> Adapter: mv64xxx_i2c adapter
>> fan1: 5461 RPM (div = 1)
>>
>> g762-i2c-0-49
>> Adapter: mv64xxx_i2c adapter
>> fan1: 5461 RPM (div = 1)
>>
> Those rpms are pretty high. Are the fans all really running that fast ?
Unlike the fans on NETGEAR ReadyNAS 102 and 104 which are Protechnic
MGT9212YB-025 92mmx92mm running at 3200 RPM max, the three fans in the
RN2120 are Protechnic MGT4012XB-O20, i.e. 40mmx40mm running at 8000 RPM
max. At least, this is the max RPM value I found on their website
(Search Products on left side of http://www.protechnic-us.com/en/) for
both devices.
When pushing one a bit, here is the max rotation speed I get:
root@thin:/sys/bus/i2c/drivers/g762/0-003e# echo 9000 > fan1_target ; \
sleep 5 ; cat fan1_input
8057
which AFAICT validates current settings for G762 and fan combination.
Did I miss something?
Cheers,
a+
next prev parent reply other threads:[~2013-11-09 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 17:39 Arnaud Ebalard
2013-11-09 18:27 ` Guenter Roeck
2013-11-09 19:42 ` Arnaud Ebalard [this message]
2013-11-09 21:17 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txflfjle.fsf@natisbad.org \
--to=arno@natisbad.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=khali@linux-fr.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®