From: Namhyung Kim <namhyung@gmail.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: Jens Axboe <axboe@kernel.dk>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch 2/2]block: add missed trace_block_plug
Date: Wed, 28 Sep 2011 17:49:58 +0900 [thread overview]
Message-ID: <87ty7xcaq1.fsf@gmail.com> (raw)
In-Reply-To: <1317179490.22361.12.camel@sli10-conroe> (Shaohua Li's message of "Wed, 28 Sep 2011 11:11:30 +0800")
Shaohua Li <shaohua.li@intel.com> writes:
> After flush plug list, the list has no request, so we need
> add a trace_block_plug.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Reviewed-by: Namhyung Kim <namhyung@gmail.com>
>
> ---
> block/blk-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux/block/blk-core.c
> ===================================================================
> --- linux.orig/block/blk-core.c 2011-09-28 11:05:22.000000000 +0800
> +++ linux/block/blk-core.c 2011-09-28 11:05:42.000000000 +0800
> @@ -1307,8 +1307,10 @@ get_rq:
> if (__rq->q != q)
> plug->should_sort = 1;
> }
> - if (request_count >= BLK_MAX_REQUEST_COUNT)
> + if (request_count >= BLK_MAX_REQUEST_COUNT) {
> blk_flush_plug_list(plug, false);
> + trace_block_plug(q);
> + }
> }
> list_add_tail(&req->queuelist, &plug->list);
> drive_stat_acct(req, 1);
prev parent reply other threads:[~2011-09-28 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 3:11 Shaohua Li
2011-09-28 8:49 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty7xcaq1.fsf@gmail.com \
--to=namhyung@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome