From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: tiwai@suse.com, navonjohnlukose@gmail.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH] ALSA: doc: cs35l56: Update calibration write failure message info
Date: Wed, 04 Nov 2026 15:44:17 +0100 [thread overview]
Message-ID: <87v76cu05a.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261104113610.1057194-1-rf@opensource.cirrus.com>
On Wed, 04 Nov 2026 12:36:10 +0100,
Richard Fitzgerald wrote:
>
> Update the descriptions of the "Failed to write calibration" and
> "Calibration disabled due to missing firmware controls" error messages.
>
> Originally "Failed to write calibration" was described as having the same
> cause as "Calibration disabled due to missing firmware controls". This
> was _typically_ true because the most likely cause of the write failure
> was missing controls (because both messages would be logged in that case).
> But it wasn't clear from the description that this was referring to the
> _typical_ root cause being the same.
>
> Reword the "Failed to write calibration" info to describe the possible
> other reasons for this error.
>
> Also slightly reword the description of "Calibration disabled due to
> missing firmware controls" to say "firmware wmfw file" instead of only
> "wmfw" and fix a missing "the" in the second bullet point. Also note
> that this is not necessarily an error, only information.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-11-04 14:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 11:36 Richard Fitzgerald
2026-11-04 14:44 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v76cu05a.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navonjohnlukose@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®