From: Takashi Iwai <tiwai@suse.de>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, cezary.rojewski@intel.com,
phucduc.bui@gmail.com, kees+treewide@kernel.org,
cassiogabrielcontato@gmail.com, mstrozek@opensource.cirrus.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: control: Clear user-provided numid before adding a control
Date: Tue, 03 Nov 2026 15:53:10 +0100 [thread overview]
Message-ID: <87v76evueh.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261102135034.2751-1-sreekuttan2156239@gmail.com>
On Mon, 02 Nov 2026 14:50:34 +0100,
Sreeraj S Kurup wrote:
>
> Clear the user-provided numid before checking for duplicate controls.
>
> A non-existing numid can cause the duplicate control ID check to be
> skipped, allowing a control with the same name and index to be added.
>
> Since the kernel assigns the numid when adding a control,
> ignore the value provided by userspace.
>
> Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-11-03 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 13:50 Sreeraj S Kurup
2026-11-03 14:53 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v76evueh.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=cezary.rojewski@intel.com \
--cc=kees+treewide@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mstrozek@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=sreekuttan2156239@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®