mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: John Stultz <jstultz@google.com>, Daehyeon Ko <4ncienth@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Miroslav Lichvar <mlichvar@redhat.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] timekeeping: Require permission to set auxiliary clocks
Date: Fri, 23 Oct 2026 21:48:56 +0200	[thread overview]
Message-ID: <87v76syz87.ffs@fw13> (raw)
In-Reply-To: <CANDhNCrZbw-JnmC6DLWp6FHe6Vait=q_0uwRE1HqdbDYjL0Zwg@mail.gmail.com>

On Wed, Oct 21 2026 at 11:29, John Stultz wrote:
> On Mon, Oct 19, 2026 at 1:03 AM Daehyeon Ko <4ncienth@gmail.com> wrote:
>> +       ret = security_settime64(tnew, NULL);
>> +       if (ret)
>> +               return ret;
>>
>>         aux_tks = &aux_tkd->shadow_timekeeper;
>
> This looked a little odd adding the security_settime64() check in the
> core timekeeping.c where as is usually called closer to the syscall in
> time.c, but given the clock_aux k_clock is defined in timekeeping.c, I
> guess this makes it the best place to add the check.

The reason why it's not in the syscall is that posix clocks have a
different permission scheme than system time, so the check ends up in
the clock_set() callback of the individial clocks.


  reply	other threads:[~2026-10-23 19:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  8:03 Daehyeon Ko
2026-10-20  2:08 ` shaos
2026-10-21 18:29 ` John Stultz
2026-10-23 19:48   ` Thomas Gleixner [this message]
2026-10-23 19:52 ` [tip: timers/urgent] " tip-bot2 for Daehyeon Ko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v76syz87.ffs@fw13 \
    --to=tglx@kernel.org \
    --cc=4ncienth@gmail.com \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlichvar@redhat.com \
    --cc=sboyd@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®