mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: dchristensen8 <dchristensen8@proton.me>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda/ca0132: Add Sound BlasterX AE-5 external RGB LED strip support
Date: Thu, 01 Oct 2026 17:20:25 +0200	[thread overview]
Message-ID: <87v77l1m86.wl-tiwai@suse.de> (raw)
In-Reply-To: <0zWxXXeew_rreqULhlodJWrfM8Ew1UwF-6S7mK25YzO6_w574QYRYOlTNbInKVbIWGVZ0ZnVPhyXchVsbgQnh6dOmle--tPNROUu6MAuhHk=@proton.me>

On Wed, 30 Sep 2026 18:09:54 +0200,
dchristensen8 wrote:
> 
> Thats genius. I reworked it with an ALSA byte control instead of sysfs and rolled in all your code cleanups for v2.
> 
> I set up two controls using IFACE_CARD and volatile:
> -AE-5 LED Strip": 300 bytes of RGB
> -AE-5 LED Strip Count: integer for setting the active strip length
> 
> Attached the v2 patch file. If you'd prefer anything named or laid out differently, just let me know.

I'm fine with those names.  Feel free to submit a proper patch for
upstreaming.

BTW, one more optimization: snd_hda_power_up() / _down() pair can be
replaced with a single call of
	CLASS(snd_hda_power_pm, pm)(codec);

Then snd_hda_power_down() will be automatically called upon its end of
code block.


thanks,

Takashi

      reply	other threads:[~2026-10-01 15:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 17:26 dchristensen8
2026-09-29 13:10 ` Takashi Iwai
2026-09-29 14:22   ` dchristensen8
2026-09-30 13:45     ` Takashi Iwai
2026-09-30 16:09       ` dchristensen8
2026-10-01 15:20         ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v77l1m86.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dchristensen8@proton.me \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®