From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCA663D9555 for ; Mon, 6 Jul 2026 10:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783334809; cv=none; b=VB4vzhz84QjbzhjLzxIkr0VrbZSzc+VmpeROvYLw6NxcR/YE6z0tkjYz200R0xdCC5gvh1HBpuWX0f0104Lj0NvOIohzS2b7W1isSDM1GOcM9Suwu4jraTO6OlH2zkuv1yaOizA2uzXxegaNskPRWWum0ITqjXyO0nvXifuaP1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783334809; c=relaxed/simple; bh=3OCy9vTyc2og6uHKZBERTMScvBxOyfL8SSA3SxVBmjM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=a4AJr73nW4tv8ddKscznnakSrLmpZPh7/zTi5/VwhU+1T8w9vbpKYFq5thaJymGpMMBPe08ApOjBwI5dQ7/cENSv/uaL+SKX8JOSHZ+LMO1Adn3NrScJX094vvNwixMT2oLwnnsWrzyloiVkn5gZG02r0Vo5yUYqbaYEm/dGm/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=U97XPHij; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RXSee13a; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U97XPHij"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RXSee13a" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783334807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v3yUXT8ygGIwRfvHBxKy7x0rY1d4D5PmMqDi5qQR4k0=; b=U97XPHij6XoHGAMCZBk4nJZWFsrhE2Glq/8H7vzL51CrgPWYeh10YxSlx3L5tK/MgfWicA vAsiTGTwzoYAutE/trcw6KyPOgMKztT1SEOBG95yl64WEoA0zsvUTDGO+ltQsTyuIxBLT2 hQMtNEDbYMgnXoxgRimTQ6tHgItUUHY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-544-xSSBPrEIOayBIfAmk3ivQA-1; Mon, 06 Jul 2026 06:46:43 -0400 X-MC-Unique: xSSBPrEIOayBIfAmk3ivQA-1 X-Mimecast-MFC-AGG-ID: xSSBPrEIOayBIfAmk3ivQA_1783334802 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-493bfc3b84aso12741505e9.0 for ; Mon, 06 Jul 2026 03:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1783334802; x=1783939602; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=v3yUXT8ygGIwRfvHBxKy7x0rY1d4D5PmMqDi5qQR4k0=; b=RXSee13a1olzy/DYa60U4WK23mG798GvWc5uT4RFLOFrcRAeIwt6VJGtev2tPa359B MKX8RXQ1k6k//LB5leyTWam398SMbxPaj7/4SXBO3DdpZYyqJmf/XRDDdhwcvtIpCVjr kqWpJnt7+7KS8mH0gVkn+uqAggQ16vC3hG/WZv/AEucTbfSGJaW8Wdlyj83HSrW8lI+U X2sTCRPlzPOHXzF+lkq/1Svuh/lz0PRfqAqfJz92xWNxrwiKG4/pq1ojtoMSX8B2Mwsv CwbzrPgygbeOO5BKfy2z3D8nJS7iK5gCbzScAQ+JX2TGcTZoj7izgyw9pRl9GIGtRdlv OcQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783334802; x=1783939602; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v3yUXT8ygGIwRfvHBxKy7x0rY1d4D5PmMqDi5qQR4k0=; b=AWNz1mQwzsORaLcF9x6QZXMYxlQuOlCOHFLHsrSAN3nJVJHPD8z1U7OTdib3RZ30Rk wdG1R2itV8/fGWqAWzA688z9SVHyqkphw2G25KANRBTfn8QfR0NSO2JAE0+vuX7tT3vR hzltHfSBNdnxvcRtyK7f1bJH7FjUfnZoQsXHhZj1Lmg8F8MevLwO+Ku2v69FvzJ8JUTe a4IwDFXaxmAD3yQ2gFRQwTGZTAL+3nXcYRuQpot+UwjzByotwpSEQW4LREtwJxXTeR8Y Z6g93QCU+CDx567f05BJY6UJD0wznN5rs8cewOdyQ459Qc9F4uF4iHll0FkIToYuYjKc clZA== X-Forwarded-Encrypted: i=1; AHgh+RqSVw1/Cy3p3+lyUe6fUoNdLTNJ2WY+0X1t0WtZm6UbPBXgNh8nHnxdfreUHuWersoVc54MVFFksosQhhY=@vger.kernel.org X-Gm-Message-State: AOJu0YwC6mu2kx8pbE4fBs+GEP0rmpDKRBg5j6MOfTGZLJxzC2/eg4GL CvdXI4zbEh7F7bOm0xVcw+DFJX44Hf0FJ2VnFTFY3RegH0BHSfLTUvyDOoKrEgkZvnmr1Rr1NVs CsveAAT5YQVnPfiasD82cxDT/uuEiEcRjshAXyCmm1X/UkVWoDqW9TFice10KTT6M+g== X-Gm-Gg: AfdE7cnit5TnF/A3ayH+6lDCFtxNnHltXYI6Irbm68ef6DJHX8y9gmnlQeQDiNHbgtv rME9GEE5VdHcnWQqg+O84DeWrOsx/NPpXsoofCSGDB8iHqJK8lk7f6BG06vMI+kbXWKORB5Nutm fA7wV8c1k3Vh2g6h5XXzijOzLT6AlVnkPPzeuKw/a2764W/+mH6nUWyLnn6Jkp7ORd1G+y0LGJk ppU0xn/fnI4dOGJRMtf67EoC7dFsNqgkAEVttkjFQ4DKMkYDzOfNHcSCZXgfs5IGU9zwfAh9+yT 3XpHFV2uhneOzTTbiw2WBo2fRFStu2GNqSppspRBn47+mHF6tc+GWVgM5y/SLqk5zqT/A5oYtnA aPqe3oRa5nyYC/uUjPeSFGa5pFmIAGCYq9S3vzFOuh73VLLtRnWadlM8QSKR+W0aNsiatrA== X-Received: by 2002:a05:600c:8b17:b0:493:bdaf:83a7 with SMTP id 5b1f17b1804b1-493d11f8c55mr115690205e9.28.1783334802400; Mon, 06 Jul 2026 03:46:42 -0700 (PDT) X-Received: by 2002:a05:600c:8b17:b0:493:bdaf:83a7 with SMTP id 5b1f17b1804b1-493d11f8c55mr115689945e9.28.1783334801980; Mon, 06 Jul 2026 03:46:41 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039b126sm23234060f8f.24.2026.07.06.03.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 03:46:41 -0700 (PDT) From: Javier Martinez Canillas To: Amit Barzilai , Andy Shevchenko , dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Barzilai Subject: Re: [PATCH v3 0/3] drm/ssd130x: Add support for the Solomon SSD1351 OLED controller In-Reply-To: <20260704080925.75113-1-amit.barzilai22@gmail.com> References: <20260704080925.75113-1-amit.barzilai22@gmail.com> Date: Mon, 06 Jul 2026 12:46:40 +0200 Message-ID: <87v7asbdkf.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Amit Barzilai writes: Hello Amit, > This series adds support for the Solomon SSD1351, a 128x128 65k-color > RGB OLED controller, to the ssd130x DRM driver: > > - Patch 1 adds the device tree binding. > > - Patch 2 switches the SSD133X family from RGB332 to RGB565, bringing > 65k color to the SSD1331. > > - Patch 3 adds the SSD1351 as a new SSD135X_FAMILY, reusing the > SSD133X plane/CRTC and blit/clear helpers. The only data-path > difference is the explicit Write RAM command (0x5c) the SSD1351 > needs before pixel data; it also gets its own init sequence. > Great, this approach looks correct to me now. I'll review this series but likely will do it in a few days. > Testing: > > - The SSD1351 (patches 1 and 3) is tested on hardware. > - The SSD1331 RGB565 change (patch 2) is compile-tested only; I do not > currently have a working SSD1331 panel. Javier has kindly offered to > test it on his SSD1331. > > Dependency: > > The SSD1351 reuses ssd133x_update_rect(), which programs the column > and row *end* address as a relative offset rather than an absolute > coordinate. This breaks partial updates that do not start at (0,0). A > separate fix is posted at [2]; until it lands, the SSD1351 shows the > same partial-redraw artifacts. This series applies independently of > that fix, but the two are best merged together. I just pushed this series to drm-misc-next, please rebase on top of that when posting a new version. > > Backlight: > > While adding the SSD1351 I noticed that the shared backlight path > (ssd130x_update_bl()) is only correct for the SSD130X and SSD132X > families, where 0x81 is the contrast command. On the SSD133X, 0x81 is > "Set Contrast for Color A", so brightness changes shift the color > balance rather than dim the panel. On the SSD1351, 0x81 is not > implemented at all and the brightness byte itself would be executed > as a command opcode (e.g. 0xae is Display OFF). This series therefore > does not register a backlight device for the SSD135X family. I plan a > follow-up making the backlight path family-aware (scaling > 0x81/0x82/0x83 together for SSD133X, 0xc1 contrast A/B/C for > SSD135X), which would also fix the existing SSD1331 behavior. Happy > to reorder if you would prefer that rework to land first. > Oh, interesting. I think your call is the right one here and this backlight logic fix / rework can be done as a follow-up series. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat