From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE2C93A8747 for ; Thu, 9 Apr 2026 10:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775729427; cv=none; b=jYPHR/nGtPppIQTrWcjgOn2KMx/eehV2cCSoRyZZN6L6r0gchG0EH5+tS1LwhOSqQzez/z8fZpqsUO357fS62LkeuO+JC8FraTEMAG0ZaUWMIcpAKzoOvgq7kLc4CRk5ialLJEK1c929JpYLRhw9X5ZstodheD+npd99/eZIha8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775729427; c=relaxed/simple; bh=C7YP/7W6rJq/hjLdvA1qt+i8erbSz+yIJ0gEOD5oY1k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UPIh8Rl1GQX8IVeCcPRHdxfw46LJqbhcDbVzxl2jNeiCZmrGORrkbZWREHPuoNeQZ9plkDcpAn3c++aHgfjGxTmtZ6WR7zqXBPnq+xZWzBE6iJLCDBT41bLiyMNOvJMtYurcEp2ciWBEUrRqG8MQ3zRHJpW+OxshIGO0PcI3zOE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YA79GtRq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rxrf7fd7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YA79GtRq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rxrf7fd7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775729423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C7YP/7W6rJq/hjLdvA1qt+i8erbSz+yIJ0gEOD5oY1k=; b=YA79GtRq8SiR7nDKzFinMENC9JyMbjGvV98V7m3+7tltdscODOEMGrDtUZCLK+b+8/9jYk b4Y/BF9KchJfsPp8MKKw1QVT/HjrLBZF9MZhfUXWGWw8ksBmmDb2VkyXKRgxfL4MU/PTpg 9hFflW9Ixc5oTfjGd5Ml7Yyn+PS7uaY= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-Ody9y5zNMFaV3hwwg1KNbw-1; Thu, 09 Apr 2026 06:10:21 -0400 X-MC-Unique: Ody9y5zNMFaV3hwwg1KNbw-1 X-Mimecast-MFC-AGG-ID: Ody9y5zNMFaV3hwwg1KNbw_1775729421 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43d5651fedaso651171f8f.2 for ; Thu, 09 Apr 2026 03:10:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775729420; x=1776334220; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=C7YP/7W6rJq/hjLdvA1qt+i8erbSz+yIJ0gEOD5oY1k=; b=rxrf7fd7LsYfV+KWGcws5fyitGONuPVbQXMrHUOt9NoZkF4p6r9TcS0SzkR1KiAzhv SV+KpSt2gsdcT3ImuH4e61jJzJTNJQC8tEU7zQRORX2/L55Mreqkm1OvxBKPxoSBu2Ku A6jvAWJv6qkGFDm4Z/lm/ML7DCzHgLZPm99JQqRn0dKK2P0/Q5uJTW7WL7oli3RCJl/a Qsv7tRKRp80Gc/Z8V1CKhS8dpZOXoN5B2tO/Rb0HkwLSIkENduz9PyMd2NN4fKip88DJ FI7SrP19Kr5wC9adCCT3emCyWkUSSFDWtND9mG7dx6MSzeID+w1ffviHAc34KbkahPlG qoDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775729420; x=1776334220; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=C7YP/7W6rJq/hjLdvA1qt+i8erbSz+yIJ0gEOD5oY1k=; b=Gsi6WCAKA7R+LdV+su9wNaAM5w5Z0OqaeaY4X+wXBO+VUNdJhYzGCBL3vNh0RMMS9w 4Si5YiWR/o5WcbdBV6d3nVK/yrc/P1jTTgot2GtqqtHuoOt4r0kbGb3m6HoDPsGQUER+ IM+xmVhsWmGyu7siK4MolCrdGc4RBEGW/RxmXYfstnK8/yKAidY9N600QDQxaZI8lggY OmoK1fhfTzKBtZEbj+agwTNDFMfXqvgWdNFHO5FT7VRcU2GSOJ8Mw+HUl1knm9IoQEoF 7K9M71vqhwxyGOS1u34zreoec01TweKjxgnOMAuH6g720JAXGTj32sL6iO5h/SJ93HGE EY3A== X-Forwarded-Encrypted: i=1; AJvYcCXnAiuNLtuyXz9LtNTNkXNE8d1R97/6fstJ9sgsIPvB5GUrDc72HCwwpFYM4dTJJuyY+ma7KknsvxsvSKI=@vger.kernel.org X-Gm-Message-State: AOJu0YxRcCQ8NTJbkiFO7KK3Hfu0Zyt/AO8beUn4wjdy7EIwUMJunGQE IfL14YHcAzKUwcpqsZLzm8Cmf4L3ZY6Yr5YLSScXtHTH6jiyWicHm365hoo8UjzFo+SVs9on5ho /cOeODjx+R44/AUAzdiLUzD5+dupnoTAcY3JoOUX1GbVTcoOPaMlN2WTEvQeGfrvHRg== X-Gm-Gg: AeBDievzx4XZu3anHt9NJncQR2MBXCSIg7a1Hl6FwhrAIKDlvU0Cpn4p6QdlUD1M+0p ajVEQ2mdx4XqroOneQoxcS4XVe1NfNp1dnoSGnUcI568ujKreSWnckwfHrnqAZrwoKYcDc5rQ3B lOK8UDGyl58vhTV0ISuwAtt2KwATqG0Lujz16QtsJbplQeOkHXPMb+tjrI2Tn2hm3jY05Zz2Ff1 0WwX+Zsrc9f1sig2tmG4Et/bcr2lmBHQ/jAROD4h8tCfxqtkSJ6xB228EINDinjZ0XhnR5YqlWD oGQh47W6NyLiTlflBuXsdGlcKdls6D5rUeuxWOQs53W/T8WVCn5eQ29Rzg0uQJBnMhHsak9vGQ+ KLix5CLf+JEnfcCNw31k68RYUtg67h97n1QnsoBmUUK2m+JdN+w== X-Received: by 2002:a05:600c:4f8a:b0:488:bf0c:a372 with SMTP id 5b1f17b1804b1-488cd0a137bmr42975065e9.31.1775729420597; Thu, 09 Apr 2026 03:10:20 -0700 (PDT) X-Received: by 2002:a05:600c:4f8a:b0:488:bf0c:a372 with SMTP id 5b1f17b1804b1-488cd0a137bmr42974485e9.31.1775729420102; Thu, 09 Apr 2026 03:10:20 -0700 (PDT) Received: from localhost ([37.221.85.123]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488cd1bb76dsm68137335e9.8.2026.04.09.03.10.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 03:10:19 -0700 (PDT) From: Javier Martinez Canillas To: Bart Van Assche , Maarten Lankhorst Cc: Maxime Ripard , linux-kernel@vger.kernel.org, Bart Van Assche , Thomas Zimmermann , Christian =?utf-8?Q?K=C3=B6nig?= , Dmitry Baryshkov , David Airlie , Simona Vetter , Nathan Chancellor Subject: Re: [PATCH] drm/fb-helper: Fix a locking bug in an error path In-Reply-To: <20260403205355.1181984-1-bvanassche@acm.org> References: <20260403205355.1181984-1-bvanassche@acm.org> Date: Thu, 09 Apr 2026 12:10:18 +0200 Message-ID: <87v7e0igvp.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bart Van Assche writes: > The name of the function __drm_fb_helper_initial_config_and_unlock() and > also the comment above that function make it clear that all code paths > in this function should unlock fb_helper->lock before returning. Add a > mutex_unlock() call in the only code path where it is missing. This has > been detected by the Clang thread-safety analyzer. > > Cc: Thomas Zimmermann > Cc: Christian K=C3=B6nig # radeon > Cc: Dmitry Baryshkov # msm > Cc: Javier Martinez Canillas > Fixes: 63c971af4036 ("drm/fb-helper: Allocate and release fb_info in sing= le place") > Signed-off-by: Bart Van Assche > --- Indeed, thanks for fixing this. Reviewed-by: Javier Martinez Canillas --=20 Best regards, Javier Martinez Canillas Core Platforms Red Hat