From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31FD220F983 for ; Tue, 14 Jan 2025 23:16:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736896612; cv=none; b=ZxtsSbjwGIMiyjEXgKvjlfDkCUAEZB0oOHDciwL9mkHQq3caUKO4PH+R0aUCyrTrOd3uy695w3z3B20yb5IKo/xGbp3maYlGnNNGTLWh1tofsw+bHW5QxXwQsYQ9J/PTzDBYuLdIS37TV4GkbLtLG6XxoCMFQQX14pbJmY20QNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736896612; c=relaxed/simple; bh=7UCtx/AjF+R7Q+8aiKYyzid2YulAcmkf3q16wQOHgnI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=VwhqNr7+35sLL1ny4puc1B3oiUNKwHchnl5vBF21nTS4+5p5cTw4OQCDCKSqBv3JCAaxai5cjVD02C2nTRY5bBvS7tpxq5/vulxR8PEr9jMJmiY5JUsDpHyaizi0UuItTeM7QajHHPS4KD6+la08KjwOSCIz0V6BFWvfYqtBmZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aqFcWQ34; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aqFcWQ34" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736896609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0CtPdOl9PYxuDf6s4TI2h/nRLxqQ12SYi0XSfHzGCmE=; b=aqFcWQ34Xyf/Vw0E3ot2SD/b6HKEFEUK0u4/1w5YyNi4OYY5W60Fm38ZwYRHxHCOnO2MVk YT87xb64zFDOkrjY9UH2zPAS8ra1ddO5A6UsBdOph47WO7rIPGDpDS6ClZdUmu6cZvxLKj WWs54DVKeJBaldnFI6IEjmjcOSMWk8w= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-33-VVl-5gYGM5iLW5OGFJ-DNA-1; Tue, 14 Jan 2025 18:16:47 -0500 X-MC-Unique: VVl-5gYGM5iLW5OGFJ-DNA-1 X-Mimecast-MFC-AGG-ID: VVl-5gYGM5iLW5OGFJ-DNA Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-388d1f6f3b2so2697337f8f.0 for ; Tue, 14 Jan 2025 15:16:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736896606; x=1737501406; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0CtPdOl9PYxuDf6s4TI2h/nRLxqQ12SYi0XSfHzGCmE=; b=XAdiCNuXDz2VIMg/3KmeXXDEv/PbyoLHsx78PzJAh/6YDUjoAXUCldb403tfLjLM3F bpZu9F11/sqj2hBcVMWnOCxDAiH72zuFQO7ClovN68t6CjuNIyHlRv00VVgHcuvcCU3B vatd+dJBabOrf7QH3rSyaSpcX/OgloZsPMi6Q9+WoKCop1R2aPA6QcwHiQRRRaoqgzg2 pYurNj1fWXa1DRZRt1WFROD/+xcQF8SbOZLZfQMMcKC8r69ipV8NIVNhWKkMz2yWiuZE u3emcJnjpIF9XQ9+D7D2TKyR7QubM9i8T9wQ7y/4mT+eIi7H45pBs7SsoOd5n72MPXIN +boA== X-Forwarded-Encrypted: i=1; AJvYcCXAD0nWuTIKQCsySXkvBJShclzgzgLyYBkRAVPMKnihHRDrnr/yKRODgVE0vh7nQZ8ObCMy0c5dcfoivX0=@vger.kernel.org X-Gm-Message-State: AOJu0YzAhrkQMtY9cywt4ntQnreKRB4FEUz0LCbxHXaDN8cU8BSztaf3 nREcwB2KXhbrLroOh0UkmaS/L4MIowENYKAWpBxyvcFRwd9/PHTGT7TiIdEAKKyELAc5sqns5AT YgmhaRS2jeejcV7E7HA2rIDnA18yJljjbNipWSfIm0QY4l7fd5SqKCrAYOghdnL8Kz36JXA== X-Gm-Gg: ASbGnctnaL9pC8Vgmzk4gIwQExGQYDTuWWVzQxpDpWPcD4WETMgnaBQrXYJS/akOIcX LbvAzbokRY39Uhp9R6QkDzv2eXE9p54BuCU3z0FK5IRyY+PZ2QdWBPoYEhe8RfYnUKZIr/Djmvh jJgKj+aREXHbpBnCJo3ZaJCC+sRqAHAArsgWPjJ7g6WfkdN37pjA4tdi4XZZeb7AgjUt2azYJW3 59XkTRjAAUqaiKwCiUw1Qg79sMZOj/Ar9J5ub7/SUHIyPB42eFogpK3aqeYj87DFuepIJStonZy TY8OoMVOXtwJ1pbXlGrQVKJqqCkvp9c/n9ayd8A= X-Received: by 2002:a05:6000:1a88:b0:38b:da6a:89f9 with SMTP id ffacd0b85a97d-38bda6a8d52mr8267000f8f.29.1736896606155; Tue, 14 Jan 2025 15:16:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGazKlV4IMrwXmxEQwELbtEyZT4yvOIkmHRJAFEvt5XojsMKfwzVF5mTaCNRQK9tXJNN/CpBw== X-Received: by 2002:a05:6000:1a88:b0:38b:da6a:89f9 with SMTP id ffacd0b85a97d-38bda6a8d52mr8266993f8f.29.1736896605849; Tue, 14 Jan 2025 15:16:45 -0800 (PST) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e37d111sm16446372f8f.18.2025.01.14.15.16.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 15:16:43 -0800 (PST) From: Javier Martinez Canillas To: John Keeping Cc: John Keeping , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drm/ssd130x: fix ssd132x encoding In-Reply-To: <20250113152752.3369731-3-jkeeping@inmusicbrands.com> References: <20250113152752.3369731-1-jkeeping@inmusicbrands.com> <20250113152752.3369731-3-jkeeping@inmusicbrands.com> Date: Wed, 15 Jan 2025 00:16:41 +0100 Message-ID: <87v7uhvvdy.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain John Keeping writes: > The ssd132x buffer is encoded one pixel per nibble, with two pixels in > each byte. When encoding and 8-bit greyscale input, take the top 4-bits I think the correct phrase is "encoding an 8-bit" ? > as the value and ensure the two pixels are distinct and do not overwrite > each other. > Fixes: fdd591e00a9c ("drm/ssd130x: Add support for the SSD132x OLED controller family") > Signed-off-by: John Keeping > --- > drivers/gpu/drm/solomon/ssd130x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c > index 2622172228361..64f1123080996 100644 > --- a/drivers/gpu/drm/solomon/ssd130x.c > +++ b/drivers/gpu/drm/solomon/ssd130x.c > @@ -880,7 +880,7 @@ static int ssd132x_update_rect(struct ssd130x_device *ssd130x, > u8 n1 = buf[i * width + j]; > u8 n2 = buf[i * width + j + 1]; > > - data_array[array_idx++] = (n2 << 4) | n1; > + data_array[array_idx++] = (n2 & 0xf0) | (n1 >> 4); > } > } Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat