From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3AEC197A0 for ; Mon, 20 Nov 2023 05:41:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231919AbjKTFlp (ORCPT ); Mon, 20 Nov 2023 00:41:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjKTFln (ORCPT ); Mon, 20 Nov 2023 00:41:43 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31321C5 for ; Sun, 19 Nov 2023 21:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700458900; x=1731994900; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=/7/+XwGPOEKnt1JtA+NEPBy+ni/uzk3f0T3/SJhZvXQ=; b=GS3HvtEEqOIvbdkh4BcTdjbvMNmiBf23TX2Sd9UGpltsDZN5sWGpUFOj bwLT4ZPzEsnFuKnpNLyvreV1aoutg/iT5R/CNlKl3rw2hVV6HJZi8t3md r4KFpJ0z+5OT+WrmYoTS3EriZ3dfNJesjcc2vRXJ0+/M8jAs7lmj2ofzC 5qtuF+XSrKeWhunYYkGWMoQQS7mkeHqQmn73cXnHzsmUKwH/v+MZ1nA8h urLupsKMHBu/muSWJOe7LLO7SbxWQx/unZBuqZlKr/LPN9RrweY9m+p+H kake/bD/mm9MqmZZT1OcMPo51Yo89s/jE7s1FMmCrjNZGJJQPEvZLqXp3 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10899"; a="13109499" X-IronPort-AV: E=Sophos;i="6.04,212,1695711600"; d="scan'208";a="13109499" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2023 21:41:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,212,1695711600"; d="scan'208";a="14046099" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2023 21:41:37 -0800 From: "Huang, Ying" To: Chris Li Cc: Yosry Ahmed , Zhongkun He , Andrew Morton , Johannes Weiner , Nhat Pham , Seth Jennings , Dan Streetman , Vitaly Wool , linux-mm , LKML Subject: Re: [PATCH] mm:zswap: fix zswap entry reclamation failure in two scenarios In-Reply-To: (Chris Li's message of "Sun, 19 Nov 2023 21:31:30 -0800") References: <20231113130601.3350915-1-hezhongkun.hzk@bytedance.com> <8734x1cdtr.fsf@yhuang6-desk2.ccr.corp.intel.com> Date: Mon, 20 Nov 2023 13:39:35 +0800 Message-ID: <87v89xasq0.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris Li writes: > On Sun, Nov 19, 2023 at 7:20=E2=80=AFPM Huang, Ying wrote: >> >> Chris Li writes: >> >> > On Thu, Nov 16, 2023 at 12:19=E2=80=AFPM Yosry Ahmed wrote: >> > That will cancel the batching effect on the swap slot free, making the >> > common case for swapping faults take longer to complete, righ? >> > If I recall correctly, the uncharge is the expensive part of the swap >> > slot free operation. >> > I just want to figure out what we are trading off against. This is not >> > one side wins all situations. >> >> Per my understanding, we don't batch memcg uncharging in >> swap_entry_free() now. Although it's possible and may improve >> performance. > > swap_entry_free() does not do batching, it is at the caller level. > > I just checked. The batching is done in free_swap_slot() is still > using swap slot cache and batching. > It uses swapcache_free_entries() to batch free the swap_slots. That is > where the uncharge happens per my understanding. Per my understanding, memcg uncharging happens in swapcache_free_entries() swap_entry_free() mem_cgroup_uncharge_swap() The swap entries are uncharged one-by-one, not acquire lock in memcg uncharge all entries release lock in memcg -- Best Regards, Huang, Ying