From: "Björn Töpel" <bjorn@kernel.org>
To: Puranjay Mohan <puranjay12@gmail.com>,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, pulehui@huawei.com,
conor.dooley@microchip.com, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yhs@fb.com, kpsingh@kernel.org, bpf@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: puranjay12@gmail.com
Subject: Re: [PATCH bpf-next v2 3/3] bpf, riscv: use prog pack allocator in the BPF JIT
Date: Sat, 26 Aug 2023 16:06:00 +0200 [thread overview]
Message-ID: <87v8d1q4on.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <20230824133135.1176709-4-puranjay12@gmail.com>
Puranjay Mohan <puranjay12@gmail.com> writes:
> Use bpf_jit_binary_pack_alloc() for memory management of JIT binaries in
> RISCV BPF JIT. The bpf_jit_binary_pack_alloc creates a pair of RW and RX
> buffers. The JIT writes the program into the RW buffer. When the JIT is
> done, the program is copied to the final RX buffer with
> bpf_jit_binary_pack_finalize.
>
> Implement bpf_arch_text_copy() and bpf_arch_text_invalidate() for RISCV
> JIT as these functions are required by bpf_jit_binary_pack allocator.
General style comment; Please try to use the full 100 characters width
for the patches. You're having a lot of linebreaks, which IMO makes the
patch harder to read.
Björn
next prev parent reply other threads:[~2023-08-26 14:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 13:31 [PATCH bpf-next v2 0/3] bpf, riscv: use BPF prog pack allocator in " Puranjay Mohan
2023-08-24 13:31 ` [PATCH bpf-next v2 1/3] riscv: extend patch_text_nosync() for multiple pages Puranjay Mohan
2023-08-24 21:57 ` Song Liu
2023-08-24 22:04 ` Puranjay Mohan
2023-08-24 13:31 ` [PATCH bpf-next v2 2/3] riscv: implement a memset like function for text Puranjay Mohan
2023-08-24 22:05 ` Song Liu
2023-08-25 1:26 ` kernel test robot
2023-08-25 7:59 ` Pu Lehui
2023-08-26 14:02 ` Björn Töpel
2023-08-24 13:31 ` [PATCH bpf-next v2 3/3] bpf, riscv: use prog pack allocator in the BPF JIT Puranjay Mohan
2023-08-24 22:19 ` Song Liu
2023-08-25 7:09 ` Pu Lehui
2023-08-25 7:34 ` Pu Lehui
2023-08-25 8:42 ` Puranjay Mohan
2023-08-25 11:12 ` Pu Lehui
2023-08-25 11:40 ` Puranjay Mohan
2023-08-26 1:36 ` Pu Lehui
2023-08-28 9:14 ` Puranjay Mohan
2023-08-26 14:06 ` Björn Töpel [this message]
2023-08-25 8:06 ` [PATCH bpf-next v2 0/3] bpf, riscv: use BPF prog pack allocator in " Pu Lehui
2023-08-25 8:16 ` Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8d1q4on.fsf@all.your.base.are.belong.to.us \
--to=bjorn@kernel.org \
--cc=andrii@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daniel@iogearbox.net \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=martin.lau@linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pulehui@huawei.com \
--cc=puranjay12@gmail.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®