From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>, Pierre Asselin <pa@panix.com>
Cc: jfalempe@redhat.com, daniel.vetter@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
hdegoede@redhat.com, ardb@kernel.org
Subject: Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated
Date: Mon, 17 Apr 2023 11:29:51 +0200 [thread overview]
Message-ID: <87v8hueu0g.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <60b7cad3-8923-98b1-2c0f-71bfabd0b2e9@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
[...]
>>
>> stride = DIV_ROUND_UP(si->lfb_width * bits_per_pixel, 8)
>
> I'd rather keep the code as-is until we get an actual bug report.
>
Ok. After all if the pixel format is chosen correctly, the reported line
length should match anyways. So is really a corner case what Pierre had.
> For example, DRM framebuffer sizes are often multiples of 64. Creating a
> framebuffer of 800x600 will create a framebuffer with
> stride/pitch/linelength of 832. I can imagine that some BIOSes out
> there do something similar with the system framebuffer. Messing with the
> stride would break them.
>
I see, is not that simple then. Thanks a lot for the clarification.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2023-04-17 9:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 15:02 Javier Martinez Canillas
2023-04-12 16:18 ` Pierre Asselin
2023-04-12 17:31 ` Javier Martinez Canillas
2023-04-12 18:12 ` Pierre Asselin
2023-04-12 18:24 ` Javier Martinez Canillas
2023-04-12 18:51 ` Pierre Asselin
2023-04-12 21:04 ` Javier Martinez Canillas
2023-04-12 21:40 ` Javier Martinez Canillas
2023-04-12 21:53 ` Pierre Asselin
2023-04-12 22:09 ` Javier Martinez Canillas
2023-04-12 23:13 ` Pierre Asselin
2023-04-13 1:13 ` Pierre Asselin
2023-04-13 1:34 ` Pierre Asselin
2023-04-17 8:15 ` Thomas Zimmermann
2023-04-17 8:58 ` Javier Martinez Canillas
2023-04-17 9:15 ` Thomas Zimmermann
2023-04-17 9:29 ` Javier Martinez Canillas [this message]
2023-04-13 7:08 ` Javier Martinez Canillas
2023-04-13 16:24 ` Pierre Asselin
2023-04-13 16:34 ` Javier Martinez Canillas
2023-04-13 17:17 ` Pierre Asselin
2023-04-13 18:04 ` Javier Martinez Canillas
2023-04-13 6:54 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8hueu0g.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=ardb@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=jfalempe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pa@panix.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®