From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4060C43334 for ; Fri, 15 Jul 2022 18:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbiGOSVN (ORCPT ); Fri, 15 Jul 2022 14:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbiGOSUx (ORCPT ); Fri, 15 Jul 2022 14:20:53 -0400 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC7746050A for ; Fri, 15 Jul 2022 11:20:52 -0700 (PDT) Received: from in02.mta.xmission.com ([166.70.13.52]:41140) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oCPvm-001XGR-Ov; Fri, 15 Jul 2022 12:20:50 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:47566 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oCPvl-006d1V-Qv; Fri, 15 Jul 2022 12:20:50 -0600 From: "Eric W. Biederman" To: Hangyu Hua Cc: akpm@linux-foundation.org, songmuchun@bytedance.com, longman@redhat.com, roman.gushchin@linux.dev, legion@kernel.org, linux-kernel@vger.kernel.org References: <20220715062301.19311-1-hbh25y@gmail.com> Date: Fri, 15 Jul 2022 13:20:23 -0500 In-Reply-To: <20220715062301.19311-1-hbh25y@gmail.com> (Hangyu Hua's message of "Fri, 15 Jul 2022 14:23:01 +0800") Message-ID: <87v8ryz194.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1oCPvl-006d1V-Qv;;;mid=<87v8ryz194.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX19CcuBbg2Xt2eAPCP9wCMd7QXP6AefhaWQ= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] ipc: mqueue: fix possible memory leak in init_mqueue_fs() X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hangyu Hua writes: > commit db7cfc380900 ("ipc: Free mq_sysctls if ipc namespace creation > failed") > > Here's a similar memory leak to the one fixed by the patch above. > retire_mq_sysctls need to be called when init_mqueue_fs fails after > setup_mq_sysctls. Alex can you review this change? > Fixes: dc55e35f9e81 ("ipc: Store mqueue sysctls in the ipc namespace") > Signed-off-by: Hangyu Hua > --- > ipc/mqueue.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ipc/mqueue.c b/ipc/mqueue.c > index 12ad7860bb88..83370fef8879 100644 > --- a/ipc/mqueue.c > +++ b/ipc/mqueue.c > @@ -1746,6 +1746,7 @@ static int __init init_mqueue_fs(void) > unregister_filesystem(&mqueue_fs_type); > out_sysctl: > kmem_cache_destroy(mqueue_inode_cachep); > + retire_mq_sysctls(&init_ipc_ns); > return error; > } Thanks, Eric