From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E1F7C433DB for ; Tue, 12 Jan 2021 11:34:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19D8F22B37 for ; Tue, 12 Jan 2021 11:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728876AbhALLeK (ORCPT ); Tue, 12 Jan 2021 06:34:10 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:53125 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbhALLeJ (ORCPT ); Tue, 12 Jan 2021 06:34:09 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610451228; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=PwKYlg6+zfHY5jZuggieGsUBveo3C3f0CdcDg4Doxeo=; b=AX3SOda6KN9/t/s7hgFO1nxLCl0ORAgfTZBbYusNjPPT3X2iZr9Q7/3KDUitg2cLtlTCP7QY 0cEU3oCvyN5IVtGv6eJUxWfyC9TQg2tH8Lbf5W68CLfaUAjjrWUNeEqfrGW9WKfniKYQ1Xey jLdPQJINWUbEn6LUeyLtwD0IvYI= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5ffd8902c88af0610730eb8d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 12 Jan 2021 11:33:22 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 15700C433C6; Tue, 12 Jan 2021 11:33:22 +0000 (UTC) Received: from tynnyri.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id AD082C433C6; Tue, 12 Jan 2021 11:33:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AD082C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Michal Kubecek Cc: linux-wireless@vger.kernel.org, Mordechay Goodstein , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , Arjen de Korte , Luca Coelho Subject: Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254) References: <20201228115814.GA5880@lion.mk-sys.cz> Date: Tue, 12 Jan 2021 13:33:14 +0200 In-Reply-To: <20201228115814.GA5880@lion.mk-sys.cz> (Michal Kubecek's message of "Mon, 28 Dec 2020 12:58:14 +0100") Message-ID: <87v9c2qtj9.fsf@tynnyri.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (adding luca) Michal Kubecek writes: > FYI, there is a regression in iwlwifi driver caused by commit > ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") > reported at > > https://bugzilla.kernel.org/show_bug.cgi?id=210733 > https://bugzilla.suse.com/show_bug.cgi?id=1180344 > > The problem seems to be an attempt to write terminating null character > into a string which may be read only. There is also a proposed fix. Can someone submit a proper patch, please? See instructions below how to submit. And please add Fixes tag to the commit log: Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches