From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 850F1C2BB1D for ; Thu, 9 Apr 2020 04:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C1A32078E for ; Thu, 9 Apr 2020 04:29:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="nkg27BHa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726470AbgDIE3u (ORCPT ); Thu, 9 Apr 2020 00:29:50 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:56801 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbgDIE3u (ORCPT ); Thu, 9 Apr 2020 00:29:50 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586406590; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=B3sXth08Y02Tmoumwkje6Jf2EC2NrHb4e6PE2kpw8bM=; b=nkg27BHaXzTFOJBqD0Cv6wFQ4J7b9KM3owNo4SCaD2x4rHMFHkVYuIwJu2EsuxvC18VIm5Kk jL7cCtfhYzQm+I2WfJjC1O8NK2tI9rYsuxNeJRQj8ieBh9duj42knlGYTj1nWHV2/e1CKXHW gatVonfn75uk4gNeqdT+ySKpvMM= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8ea4b9.7f540a9fd420-smtp-out-n04; Thu, 09 Apr 2020 04:29:45 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AE7F7C43637; Thu, 9 Apr 2020 04:29:44 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id BCE66C433F2; Thu, 9 Apr 2020 04:29:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BCE66C433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: Yan-Hsuan Chuang , Chin-Yen Lee , "David S. Miller" , Brian Norris , Chris Chiu , Jian-Hong Pan , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtw88: avoid unused function warnings References: <20200408185413.218643-1-arnd@arndb.de> Date: Thu, 09 Apr 2020 07:29:39 +0300 In-Reply-To: <20200408185413.218643-1-arnd@arndb.de> (Arnd Bergmann's message of "Wed, 8 Apr 2020 20:53:51 +0200") Message-ID: <87v9m9uvrg.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > The rtw88 driver defines emtpy functions with multiple indirections > but gets one of these wrong: > > drivers/net/wireless/realtek/rtw88/pci.c:1347:12: error: 'rtw_pci_resume' defined but not used [-Werror=unused-function] > 1347 | static int rtw_pci_resume(struct device *dev) > | ^~~~~~~~~~~~~~ > drivers/net/wireless/realtek/rtw88/pci.c:1342:12: error: 'rtw_pci_suspend' defined but not used [-Werror=unused-function] > 1342 | static int rtw_pci_suspend(struct device *dev) > > Better simplify it to rely on the conditional reference in > SIMPLE_DEV_PM_OPS(), and mark the functions as __maybe_unused to avoid > warning about it. > > I'm not sure if these are needed at all given that the functions > don't do anything, but they were only recently added. > > Fixes: 44bc17f7f5b3 ("rtw88: support wowlan feature for 8822c") > Signed-off-by: Arnd Bergmann I'll queue this to v5.7. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches