From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A62C2BB1D for ; Mon, 16 Mar 2020 13:05:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C819205ED for ; Mon, 16 Mar 2020 13:05:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=axtens.net header.i=@axtens.net header.b="HC5iw9ns" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731150AbgCPNFl (ORCPT ); Mon, 16 Mar 2020 09:05:41 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:37776 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730974AbgCPNFl (ORCPT ); Mon, 16 Mar 2020 09:05:41 -0400 Received: by mail-pf1-f196.google.com with SMTP id 3so2051714pff.4 for ; Mon, 16 Mar 2020 06:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=S3ylSoSVkSVtheK/F1qvWvf0XZ/cN1+4cUsuDfSQPrg=; b=HC5iw9nsPFCCHJIQ4FigojhiQRRfcdyb6Qpgcbl9eWbw97vM6ByH1GNo0POUcLpnq8 W2526eX+MuNa5a/YiPRQpKhHy989nZbvMYd0iQ068YzwHi/XfEMOAHswjNqJkdwQO/xa W0/LGixqd91m0pYY9vhfsXQG0Fssoiruwz8xI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=S3ylSoSVkSVtheK/F1qvWvf0XZ/cN1+4cUsuDfSQPrg=; b=gnbFSZ20YHXaOnKWCp9mjwaacTf/k+vtibvm3zgdsRsqdBCzVbNNeheY9XcYHS6lxq yarESRbEe4uR6+jvvUzdF5motOD+hEObmnJiXXGr668c9vNJF2zkKIIbP68pnkUBPmQu a/cbApbg+uMjuw5CCO7hPQGoR9BT9nX1+ZwsLBrHSLEoVKvCZpJrAdeW3qveKvSKjJiu MHVD7UrlITA+zKKWJOtRfSso0VIvcCcZMjBFZriSW9lZCLAN4oG3OmGOlpaXENy8TmAO a94v39kKuT82itzkpjaYWdnuuSrXyRh/bKjRJ10pyUTaeLM7VLCBAFZiLsZg4IpZ1ZHa xTqA== X-Gm-Message-State: ANhLgQ0WlYxDDeL+oEE8x7L5R2buUxAeKdPTUFmEPcgJNkRSX6WlJ4Jp crz/L5XVDT0vOKicvnTP4pWzIg== X-Google-Smtp-Source: ADFU+vte8YprRXpiosPh6oK8UzgBCXexYDX8dInWwsIZfEzpUDJTBrqtjf9QP5Ukzx4PTdYLK6yJpw== X-Received: by 2002:a63:5506:: with SMTP id j6mr26894163pgb.43.1584363939827; Mon, 16 Mar 2020 06:05:39 -0700 (PDT) Received: from localhost (2001-44b8-1113-6700-789d-cd2c-42e1-23af.static.ipv6.internode.on.net. [2001:44b8:1113:6700:789d:cd2c:42e1:23af]) by smtp.gmail.com with ESMTPSA id z15sm32281786pfg.152.2020.03.16.06.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 06:05:38 -0700 (PDT) From: Daniel Axtens To: Pratik Rajesh Sampat , linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, psampat@linux.ibm.com, pratik.r.sampat@gmail.com, ego@linux.vnet.ibm.com Subject: Re: [PATCH] Fixes: 227942809b52 ("cpufreq: powernv: Restore cpu frequency to policy->cur on unthrottling") In-Reply-To: <20200306110549.25517-1-psampat@linux.ibm.com> References: <20200306110549.25517-1-psampat@linux.ibm.com> Date: Tue, 17 Mar 2020 00:05:35 +1100 Message-ID: <87v9n4o3fk.fsf@dja-thinkpad.axtens.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pratik, Please could you resend this with a more meaningful subject line and move the Fixes: line to immediately above your signed-off-by? Thanks! Regards, Daniel > The patch avoids allocating cpufreq_policy on stack hence fixing frame > size overflow in 'powernv_cpufreq_work_fn' > > Signed-off-by: Pratik Rajesh Sampat > --- > drivers/cpufreq/powernv-cpufreq.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index 56f4bc0d209e..20ee0661555a 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -902,6 +902,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb = { > void powernv_cpufreq_work_fn(struct work_struct *work) > { > struct chip *chip = container_of(work, struct chip, throttle); > + struct cpufreq_policy *policy; > unsigned int cpu; > cpumask_t mask; > > @@ -916,12 +917,14 @@ void powernv_cpufreq_work_fn(struct work_struct *work) > chip->restore = false; > for_each_cpu(cpu, &mask) { > int index; > - struct cpufreq_policy policy; > > - cpufreq_get_policy(&policy, cpu); > - index = cpufreq_table_find_index_c(&policy, policy.cur); > - powernv_cpufreq_target_index(&policy, index); > - cpumask_andnot(&mask, &mask, policy.cpus); > + policy = cpufreq_cpu_get(cpu); > + if (!policy) > + continue; > + index = cpufreq_table_find_index_c(policy, policy->cur); > + powernv_cpufreq_target_index(policy, index); > + cpumask_andnot(&mask, &mask, policy->cpus); > + cpufreq_cpu_put(policy); > } > out: > put_online_cpus(); > -- > 2.17.1