From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932329AbeAXArG (ORCPT ); Tue, 23 Jan 2018 19:47:06 -0500 Received: from ozlabs.org ([103.22.144.67]:45937 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932083AbeAXArF (ORCPT ); Tue, 23 Jan 2018 19:47:05 -0500 From: Michael Ellerman To: "Gustavo A. R. Silva" , Benjamin Herrenschmidt Cc: "Gustavo A. R. Silva" , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers/macintosh: Use true for boolean value In-Reply-To: <20180123174349.GA19627@embeddedgus> References: <20180123174349.GA19627@embeddedgus> Date: Wed, 24 Jan 2018 11:47:02 +1100 Message-ID: <87vafsulq1.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Gustavo A. R. Silva" writes: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/macintosh/windfarm_pm72.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This seems to be common across all those drivers. Can you please send one patch to fix them all to use bool: $ git grep "started = " drivers/macintosh/ drivers/macintosh/therm_adt746x.c: int started = 0; drivers/macintosh/therm_adt746x.c: started = 1; drivers/macintosh/windfarm_pm112.c: slots_started = 1; drivers/macintosh/windfarm_pm112.c: started = 1; drivers/macintosh/windfarm_pm121.c: pm121_started = 1; drivers/macintosh/windfarm_pm72.c: started = 1; drivers/macintosh/windfarm_pm81.c: wf_smu_started = 1; drivers/macintosh/windfarm_pm91.c: wf_smu_started = 1; drivers/macintosh/windfarm_rm31.c: started = 1; cheers