From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392AbdCAJtx (ORCPT ); Wed, 1 Mar 2017 04:49:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49446 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbdCAJtu (ORCPT ); Wed, 1 Mar 2017 04:49:50 -0500 From: Vitaly Kuznetsov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky , x86@kernel.org, Andrew Jones , linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH 1/5] x86/xen: start untangling PV and PVHVM guest support code References: <20170224161440.2136-1-vkuznets@redhat.com> <20170224161440.2136-2-vkuznets@redhat.com> <58638497-6660-6119-e24d-d2a8b05d99b0@suse.com> Date: Wed, 01 Mar 2017 10:38:49 +0100 In-Reply-To: <58638497-6660-6119-e24d-d2a8b05d99b0@suse.com> (Juergen Gross's message of "Wed, 1 Mar 2017 07:22:05 +0100") Message-ID: <87varttjyu.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 01 Mar 2017 09:38:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Juergen Gross writes: > On 24/02/17 17:14, Vitaly Kuznetsov wrote: >> Introduce CONFIG_XEN_PV config option and split enlighten.c into >> 4 files. Temporary add #ifdef CONFIG_XEN_PV to smp.c and mmu.c to >> not break the build and not make the patch even bigger. >> >> xen_cpu_up_prepare*/xen_cpu_die hooks require separation to support >> future xen_smp_intr_init() split. >> >> Signed-off-by: Vitaly Kuznetsov > > Could you please split pure code movement and functional changes into > different patches? This would make review much easier. > It's a bit hard with this series to make patches smaller and not break the build ... :-( > So 1 patch to split up enlightenment.c and at least one patch for the > rest of the changes (Kconfig, splitting of x86_hyper_xen, ...). This sounds doable, I'll try! -- Vitaly