From: Michael Ellerman <mpe@ellerman.id.au>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
imunsie@au1.ibm.com, fbarrat@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cxl: Fix error handling
Date: Mon, 31 Oct 2016 20:50:12 +1100 [thread overview]
Message-ID: <87vaw826gb.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <e6e4eb09-28d1-ad7c-6ab3-8e954c27ed23@au1.ibm.com>
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes:
> On 31/10/16 08:34, Christophe JAILLET wrote:
>> 'cxl_dev_context_init()' returns an error pointer in case of error, not
>> NULL. So test it with IS_ERR.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>
>> ---
>> un-compiled because I don't have the required cross build environment.
>
> Builds fine here.
>
> In future, you might want to bundle all 3 of your patches either into 1
> patch (while they are changes which can be done separately, it's all
> fixes to one type of problem in relation to one function, so personally
> I'm okay with that) or send it as a series, so that it's clear to
> everyone that they're all related fixes.
> Additionally, having the same patch subject line for two patches sent in
> short succession is a bit confusing - in future, try and avoid that.
Yeah. I actually assumed it was two versions of the same patch.
cheers
next prev parent reply other threads:[~2016-10-31 9:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 21:34 Christophe JAILLET
2016-10-31 6:27 ` Andrew Donnellan
2016-10-31 9:50 ` Michael Ellerman [this message]
2016-11-16 1:54 ` Ian Munsie
2016-11-22 0:34 ` Michael Ellerman
2016-10-30 21:40 [PATCH] " Christophe JAILLET
2016-10-31 5:37 ` Michael Ellerman
2016-11-01 23:36 ` Jim Davis
2016-11-02 11:12 ` Michael Ellerman
2016-11-02 19:01 ` Jim Davis
2016-11-03 9:55 ` Michael Ellerman
2016-10-31 6:27 ` Andrew Donnellan
2016-11-02 16:50 ` Frederic Barrat
2016-11-16 1:56 ` Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaw826gb.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=andrew.donnellan@au1.ibm.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®