From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Pengcheng Li <lpc.li@hisilicon.com>, johnyoun@synopsys.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, xuejiancheng@hisilicon.com,
lidongpo@hisilicon.com, caizhiyong@hisilicon.com,
Pengcheng Li <lpc.li@hisilicon.com>
Subject: Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting
Date: Mon, 17 Oct 2016 12:37:10 +0300 [thread overview]
Message-ID: <87vawrs4e1.fsf@linux.intel.com> (raw)
In-Reply-To: <1474634096-106548-1-git-send-email-lpc.li@hisilicon.com>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
Hi,
Pengcheng Li <lpc.li@hisilicon.com> writes:
> The USBTRDTIM field needs to be cleared before setting a new value.
> Otherwise it will result in an incorrect value if phyif == GUSBCFG_PHYIF8.
>
> Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f
> Signed-off-by: Pengcheng Li <lpc.li@hisilicon.com>
> Acked-by: John Youn <johnyoun@synopsys.com>
which commit are you fixing? Seems like you're missing a:
Fixes: foobar ....
line here. Also, you need to remove Gerritisms from commit log ;-)
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
next prev parent reply other threads:[~2016-10-17 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 12:34 Pengcheng Li
2016-10-17 9:37 ` Felipe Balbi [this message]
2016-10-22 1:44 ` Lipengcheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vawrs4e1.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=caizhiyong@hisilicon.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnyoun@synopsys.com \
--cc=lidongpo@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lpc.li@hisilicon.com \
--cc=xuejiancheng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome