From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932124AbcH0PjW (ORCPT ); Sat, 27 Aug 2016 11:39:22 -0400 Received: from smtp02.smtpout.orange.fr ([80.12.242.124]:46054 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754185AbcH0PjV (ORCPT ); Sat, 27 Aug 2016 11:39:21 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 27 Aug 2016 17:30:47 +0200 X-ME-IP: 109.222.65.159 From: Robert Jarzmik To: Russell King - ARM Linux Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Nicolas Pitre , "David S. Miller" , Yoshinori Sato , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes References: <20160825144314.1850730-1-arnd@arndb.de> <3062310.z9h3CgCZ7p@wuerfel> <87inuopw04.fsf@belgarion.home> <20160825223743.GK1041@n2100.armlinux.org.uk> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 27 Aug 2016 17:30:42 +0200 Message-ID: <87vaymdyal.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Russell King - ARM Linux writes: > On Thu, Aug 25, 2016 at 08:02:35PM +0200, Robert Jarzmik wrote: >> Arnd Bergmann writes: >> >> > On Thursday, August 25, 2016 4:43:04 PM CEST Arnd Bergmann wrote: >> >> drivers/net/ethernet/smsc/smc91x.h | 50 +++++++++++++++++++++++--------------- >> >> 1 file changed, 30 insertions(+), 20 deletions(-) >> >> >> >> While this patch fixes one bug on Neponset, it probably doesn't address >> >> the one that Russell ran into first, so this is for review only for now, >> >> until the remaining problem(s) have been worked out. >> >> >> > >> > The comment should have been on another patch, my mistake. please >> > see v2. >> > >> > Arnd >> >> Hi Arnd, >> >> I didn't review the patch thoroughly, but I launched your 2 patches in my pxa >> little farm. >> >> The result is that lubbock and mainstone are all right, but zylonite is broken >> (ie. networkless). I removed then these 2 patches and zylonite worked again. >> >> I have also an error message on the console on a "broken" zylonite : >> Changing smcs91x MAC address to 08:00:3e:26:0a:5b: ifconfig: SIOCSIFHWADDR: >> Device or resource busy >> >> I reran the test twice (2 times with your patches, 2 times without), the result >> looks consistent, ie. zylonite doesn't really like them. > > Please try the patch below. I sent this to Will a few days ago, as > he said (on irc) that he was also seeing problems on a platform he > had, but I've yet to hear back. I've not posted it yet because I > haven't got around to writing a commit description for it. > > It does require that at least one of 8-bit or 16-bit accesses are > supported, but I think that's already true. Hi Russell, With your patch : - lubbock, mainstone and zylonite boards are working correctly => ie. all my boards are working correctly - the message "ifconfig: SIOCSIFHWADDR: Device or resource busy" is still there => this message is here even without your patch, so it's rather not relevant => this message is triggered by an "/sbin/ifconfig eth0 hw ether 08:00:3e:26:0a:5b" command So from a PXA testing point of view it's all good, ie. Tested-by: Robert Jarzmik Cheers. -- Robert