From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524AbcHCD70 (ORCPT ); Tue, 2 Aug 2016 23:59:26 -0400 Received: from ozlabs.org ([103.22.144.67]:59564 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753558AbcHCD7U (ORCPT ); Tue, 2 Aug 2016 23:59:20 -0400 From: Michael Ellerman To: Paolo Bonzini , torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, rkrcmar@redhat.com, kvm@vger.kernel.org, Christian Borntraeger , Christoffer Dall , Dan Williams , Marc Zyngier , Paul Mackerras Subject: Re: [GIT PULL] KVM changes for 4.8 merge window In-Reply-To: <1470141468-120437-1-git-send-email-pbonzini@redhat.com> References: <1470141468-120437-1-git-send-email-pbonzini@redhat.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Wed, 03 Aug 2016 13:21:49 +1000 Message-ID: <87vazilepe.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paolo Bonzini writes: ... > - arch/powerpc: what a mess. For the idle_book3s.S conflict, the KVM > tree is the right one; everything else is trivial. In this case I am > not quite sure what went wrong. The commit that is causing the mess > (fd7bacbca47a, "KVM: PPC: Book3S HV: Fix TB corruption in guest exit > path on HMI interrupt", 2016-05-15) touches both arch/powerpc/kernel/ > and arch/powerpc/kvm/. It's large, but at 396 insertions/5 deletions > I guessed that it wasn't really possible to split it and that the 5 > deletions wouldn't conflict. That wasn't the case. In fact I think the problem is that this patch shouldn't have gone via the KVM tree at all. If you look at the diffstat, it doesn't touch anything in generic KVM, but lots of arch code: arch/powerpc/include/asm/hmi.h | 45 ++++++++++++++++++++ arch/powerpc/include/asm/paca.h | 6 +++ arch/powerpc/kernel/Makefile | 2 +- arch/powerpc/kernel/exceptions-64s.S | 4 +- arch/powerpc/kernel/hmi.c | 56 +++++++++++++++++++++++++ arch/powerpc/kernel/idle_power7.S | 5 ++- arch/powerpc/kernel/traps.c | 5 +++ arch/powerpc/kvm/book3s_hv.c | 37 +++++++++++++++++ arch/powerpc/kvm/book3s_hv_ras.c | 176 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ arch/powerpc/kvm/book3s_hv_rmhandlers.S | 65 ++++++++++++++++++++++++++++- Presumably Paul wanted it in his kvm-ppc tree so it would be tested with the rest of the KVM stuff, but we should have done that with a topic branch in the powerpc tree, that we both merged. cheers