From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753975AbbINCGI (ORCPT ); Sun, 13 Sep 2015 22:06:08 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:55910 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753517AbbINCGF (ORCPT ); Sun, 13 Sep 2015 22:06:05 -0400 X-IronPort-AV: E=Sophos;i="5.17,525,1437404400"; d="scan'";a="195527799" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Message-ID: <87vbbdkbcm.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Arnd Bergmann CC: Simon , Greg Kroah-Hartman , , Magnus , Subject: Re: [PATCH] misc: add CS2000 Fractional-N driver In-Reply-To: <1702135.nL3RG8RPso@wuerfel> References: <87mvwuokd3.wl%kuninori.morimoto.gx@renesas.com> <1702135.nL3RG8RPso@wuerfel> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Mon, 14 Sep 2015 02:05:58 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TY1PR06CA0028.apcprd06.prod.outlook.com (25.164.91.38) To SG2PR06MB0603.apcprd06.prod.outlook.com (25.161.10.153) X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB0603;2:RQDIm/BcPDNO3ZNd3PjiWIdtMkGVZ+BlKrWcIpna1H7yVohs4AfQUU5cLEkxISV/55snMLgWzYHyXtorZ3tBS/ATrv1gtI2bJflphQijY5LzNOPLMJpvetxei4jJ0lsQRBtWqfrBKNBNAtlIgUoVSJSA2aKq4EjRB4+cDVHaRK0=;3:v8HFrjoBptp8A3ainJULG2GRp2fcvy9wGp5aMi1wuCPlr6o86+uNSJAe3QQdJsMaF5RJcGJkeoF/UjdVfrlTLHj19yQJUq8ZIOQb1zpZJKIWfPNIaAamkL1KAKK5Q2prw88VGbxsKLvemkQhWYDXFQ==;25:YW2cgNY2y21+dUaWitz9qjdDwmD1VuP99MHMDAqCZK0PCC3S1MKTKditSQ4IU8yzRBdZaHLD6HuPEBZVoSuDF39ZwMj/6e5+08MFOvgPGWSAJP4XF2WJWUnXj9tqQDjti/BvC6F0ioHOsJ6DNTDFsOrhU5ExlEEruhifnKPrv6ARTG0L3obmsvrzm7Z4gAXaElFLO0hQwNw9nj3rYuKW45r0jYdp2+/C1Wy0Wkup/IQgJEaJS+jiXdMrU5KbMjFPVJhD0n6iYxg2ml/Z8hwxSw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0603; X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB0603;20:E5pZdBFGOyqWMKWKnESV8G+NUTwYJoIPZJ5rlh6hQXQaSRMfrcxcFLFj1+3oPuHdaqXov/FfeZPxk9y5EuH4U/gMAOT1c6OhcT5+djN+JM8sLc0xw6qNlYG5VDZWdy4cvJeW8aat8UGJgYft1FddnISCEUAxvHg21FhmA6SrX7QFWGTsZxNLOIMF0eTOBHQnT91r5JW0c5PCmAIast7VMWSGeDhMde5ATSNhA/tNgw6ZRyXD/2EOai0fMhcxi0HSWIWsvQNiayrARSY7RGkoSKLqzSN1m9layG4Ar2bHiVeNvB3/0WRzlMvkeoQrF4+awVuGFPxDuEP9lBBCd2wbP5Hf36HNJtcpJADSCgZojhqg3e833dygjDKD30KugHEapkm8IKk/iEVOaJM2GmK+nLI8bbmO5FgD25kPATPtrDj6r/56JL9va04f8/h6q/cCWrlf8jy3b5eXBGUwSqfOQgqotHuPnISY+qCxSNacKs+L2jzo0N3M9PD8lXE288kx;4:xn9z1tOi3tTlCKDgE76G2fK/t47itYqtaDguLGVJog76KmB0QqdWjfRgxFVkqyI6baqqG1eQa8N+768lKUeimcH3ucj9SVua2FeHZPGP4s255GTSdVZmwYqyTWp5CjPo4jn4/R7at26uoexhp82t+cz6FhaV+cG6WVJ/pbRTPJf33RG65mKKAOVLl3B3bIQTXyBoCpeOTgHFsl4RUBSKWG3fU4boUefk8H7iUbzv/VrAPCx6fH3oY2PWMzv+gGDjB2TYzQgyqZzzcUYc78Fwy0beVuKZgHmuVJ82B3L7myKR1VHSEvTfWMiwKY2PoVU8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:SG2PR06MB0603;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB0603; X-Forefront-PRVS: 0699FCD394 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(189002)(19580395003)(50466002)(69596002)(19580405001)(87976001)(2950100001)(106356001)(83506001)(46102003)(23726002)(46406003)(101416001)(42186005)(54356999)(53416004)(50986999)(76176999)(66066001)(86362001)(64706001)(105586002)(47776003)(5001860100001)(68736005)(4001350100001)(5004730100002)(77096005)(5001960100002)(110136002)(5007970100001)(36756003)(40100003)(62966003)(77156002)(122386002)(33646002)(92566002)(189998001)(97736004)(81156007)(4001540100001)(5001830100001)(5001920100001);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB0603;H:morimoto-PC.renesas.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SG2PR06MB0603;23:0yjMOsR2ZBtsVjgSi2SCOXPTxSgklSO/qUdTgj2oW?= =?us-ascii?Q?xTebn1AwotUVvdDJjefn9xVR6/tnrE0u80LOKCsSHEP010nAFXavAzKTNmCe?= =?us-ascii?Q?8H3IMyIf5hTsAIu6I3R9q1ntQSjN6fZxHsTSk0O3taHecQegGQPCxYuNnlrs?= =?us-ascii?Q?+OE9xERUq9tQvdepKc7kwuqK7P624gr9f7oF+XH15r29HLqppIG6OHQFo+KC?= =?us-ascii?Q?qspG/GeptMSZBotWFS9uB8GfufSzMi5PszY5IuFxq/kwNSjNJRdONlPUmD82?= =?us-ascii?Q?1q00w9X6C3CyLc5YcSd3KR2bpc/b9X7COHraOdeQ0EqKgL5b9Rpawd+j9fW7?= =?us-ascii?Q?/Ku5z2eCg68NQPEQHnbikHmV84JSD/RFtTXxygI1C4mipnY4MziWhh8SKWvS?= =?us-ascii?Q?74JC1qT1AuenPt+7yuvNbfBIo95HOnuadg5bQ6PZIUO1pMJSHXdFtHWA4wRF?= =?us-ascii?Q?tSsv+MV+0KgbSpRXU9RG1cLoUt5DgBVJl6vJ6ZR4NShazhWGCnEsGKtH7fAi?= =?us-ascii?Q?nWevEoTCmYBmZaUGrI3c6+CFfyHpOnPyR+jXyJwE4dC9R4tHAQTq//ZvojGN?= =?us-ascii?Q?c652MgJxROh4TQ64fS9aAN0bNHx89p/uD3g5tXVYPtXB5WzR2TEzcmq68pcM?= =?us-ascii?Q?pMnNwOCOb9Av1rfraZgH1GtNd7aiG3ZUNVm6AQkuJfhPIt1yGgEuF+RNX8dY?= =?us-ascii?Q?roJ0Kge8xeWvm5NkTk6RPET+uiwEt81SFgkBzpHbeROEKFuA0DA+/1e7BP37?= =?us-ascii?Q?oByY2mbhAgnuSbE00801it/Ce3SaVVgXJYcT1K062LL3b0sYZygqAuqpF6lO?= =?us-ascii?Q?c2NBW3H3rCRsmnL0t4LjAengGYol2LHPZekYHdRdgVCvMTSFmR6EQ6rykWMS?= =?us-ascii?Q?LrrYI/hU7G/j8Aq6zXOwOLGxX8OF7d7OyE5iROq5sohDrVMB62Ae5Q5oxYQd?= =?us-ascii?Q?uqHfObPfZn50Hf6PpALArT4Ax2k3NxiYN8zkEOnNTD4eqE1KH9PIH+B4caKl?= =?us-ascii?Q?uPgbz9X3u6o3U5K3o78IDO0AN9Ua8r8wa797FKII6bP/1y4+VTlw0rka/2Sr?= =?us-ascii?Q?49L6WD1w6oAcsbE/EbBT/+kyELCqJR92zPBzOebMDmrOdiwhJosWJJZnevYI?= =?us-ascii?Q?u+YPE2Hz+jhVJ5Xs5NlPCEmjHce6we8So1J9USikz42RrkUV59sRQDZgSNdr?= =?us-ascii?Q?Oq1xhTKGxmQJu4O45GXSeYvv5pbJB5hNKELZNikX/mPLfeHZvPi9d101A+Mx?= =?us-ascii?Q?JN74ZqvqdJf9BoKf1k=3D?= X-Microsoft-Exchange-Diagnostics: 1;SG2PR06MB0603;5:6AxDCyzQ8EnB7ShuM6neXDkRKNMFs5hD75KFPJqlST/JH/UaF8QGYYHRp8Cn/aLmEIJERWAtTvSg3QAJ2xBID9BKqd1CUVW7P8zXJbc9DQJ+XEqGIgllHlJZqAOAVLc1Q6q0qAgDDK6Kh2d3cng4nw==;24:ZrvbIxNxnF2B+pZr47omZV4wdwWfj7QJVJ/6feb0lnDPp8dVhnAusshB/zt176rz8nKbtPimQfpNUOzusnXKQNP1VOGGxfXQmc8rj7QjaeQ=;20:QD1Ta/uAUzl2KQAXxvsyV2K51GGQUkGKnITqP1nOhWXvsRiNO6nOWbU2pVRwxCnIuUoorzqLdD4CiZws37AJm+VIhcc2cvq5iXDw0a2oJWJNLqFBEAPq2l4HRJ6EutVvDvblSV60gVHDt6lkUYawAroEMmUfv4AiWonAkywryFY= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2015 02:05:58.4764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB0603 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd Thank you for your feedback > > From: Kuninori Morimoto > > > > This patch adds CS2000 Fractional-N driver as clock provider. > > It is useful if it supports runtime clock setting, but it supports > > fixed clock rate at this point. > > > > Signed-off-by: Kuninori Morimoto > > --- > > .../devicetree/bindings/misc/cs2000-cp.txt | 20 ++ > > drivers/misc/Kconfig | 6 + > > drivers/misc/Makefile | 1 + > > drivers/misc/cs2000-cp.c | 341 +++++++++++++++++++++ > > 4 files changed, 368 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/misc/cs2000-cp.txt > > create mode 100644 drivers/misc/cs2000-cp.c > > I think the driver should be in drivers/clk/ if it provides a clk to > other devices. > > Please also split out the binding document into a separate patch and > Cc the devicetree mailing list. OK, thanks I will do it, and send to clock ML > > + ret = cs2000_get_clk(client, &rate_in, &rate_out); > > + if (ret < 0) > > + return ret; > > + > > + ret = cs2000_enable_dev_config(client); > > + if (ret < 0) > > + return ret; > > + > > + ret = cs2000_clk_in_bound_rate(client, rate_in); > > + if (ret < 0) > > + return ret; > > + > > + ret = cs2000_ratio_set(client, ch, rate_in, rate_out); > > + if (ret < 0) > > + return ret; > > The probe function lacks unwinding if anything goes wrong, so you end > up with clocks that are registered but the driver being absent. > For most things, you can use the devm_*() interfaces here. I got it. Thanks Best regards --- Kuninori Morimoto