From: Rusty Russell <rusty@rustcorp.com.au>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Luis R . Rodriguez" <mcgrof@suse.com>, Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@linux.intel.com>,
Olof Johansson <olof@lixom.net>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Subject: Re: [PATCH 7/8] module: add core_param_unsafe
Date: Tue, 20 Jan 2015 16:13:38 +1030 [thread overview]
Message-ID: <87vbk2atx1.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1421451197-19723-8-git-send-email-dmitry.torokhov@gmail.com>
Dmitry Torokhov <dmitry.torokhov@gmail.com> writes:
> Similarly to module_param_unsafe(), add the helper to be used by core
> code wishing to expose unsafe debugging or testing parameters that taint
> the kernel when set.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks,
Rusty.
> ---
> include/linux/moduleparam.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
> index 1392370..6480dca 100644
> --- a/include/linux/moduleparam.h
> +++ b/include/linux/moduleparam.h
> @@ -310,6 +310,15 @@ static inline void __kernel_param_unlock(void)
> #define core_param(name, var, type, perm) \
> param_check_##type(name, &(var)); \
> __module_param_call("", name, ¶m_ops_##type, &var, perm, -1, 0)
> +
> +/**
> + * core_param_unsafe - same as core_param but taints kernel
> + */
> +#define core_param_unsafe(name, var, type, perm) \
> + param_check_##type(name, &(var)); \
> + __module_param_call("", name, ¶m_ops_##type, &var, perm, \
> + -1, KERNEL_PARAM_FL_UNSAFE)
> +
> #endif /* !MODULE */
>
> /**
> --
> 2.2.0.rc0.207.ga3a616c
next prev parent reply other threads:[~2015-01-20 5:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 23:33 [PATCH 0/8] Asynchronous device/driver probing support Dmitry Torokhov
2015-01-16 23:33 ` [PATCH 1/8] module: add extra argument for parse_params() callback Dmitry Torokhov
2015-01-16 23:33 ` [PATCH 2/8] driver-core: add asynchronous probing support for drivers Dmitry Torokhov
2015-01-16 23:33 ` [PATCH 3/8] driver-core: add driver module asynchronous probe support Dmitry Torokhov
2015-01-16 23:33 ` [PATCH 4/8] driver-core: enable drivers to opt-out of async probe Dmitry Torokhov
2015-01-16 23:33 ` [PATCH 5/8] driver-core: platform_driver_probe() must probe synchronously Dmitry Torokhov
2015-01-16 23:33 ` [PATCH 6/8] amd64_edac: enforce synchronous probe Dmitry Torokhov
2015-03-18 16:56 ` Tejun Heo
2015-03-18 17:45 ` Dmitry Torokhov
2015-03-18 17:50 ` Dmitry Torokhov
2015-03-18 18:16 ` Tejun Heo
2015-03-18 18:23 ` Dmitry Torokhov
2015-03-18 18:27 ` Tejun Heo
2015-03-18 18:37 ` Dmitry Torokhov
2015-03-18 18:45 ` Tejun Heo
2015-03-18 19:36 ` Dmitry Torokhov
2015-03-18 19:51 ` Tejun Heo
2015-03-18 20:26 ` Dmitry Torokhov
2015-03-18 21:02 ` Tejun Heo
2015-03-18 21:41 ` Dmitry Torokhov
2015-03-18 21:50 ` Tejun Heo
2015-03-18 22:15 ` Dmitry Torokhov
2015-03-18 23:24 ` Tejun Heo
2015-03-19 0:26 ` Dmitry Torokhov
2015-03-19 15:41 ` Tejun Heo
2015-03-19 16:01 ` Dmitry Torokhov
2015-03-19 16:19 ` Tejun Heo
2015-03-19 17:04 ` Dmitry Torokhov
2015-01-16 23:33 ` [PATCH 7/8] module: add core_param_unsafe Dmitry Torokhov
2015-01-20 5:43 ` Rusty Russell [this message]
2015-01-16 23:33 ` [PATCH 8/8] driver-core: allow forcing async probing for modules and builtins Dmitry Torokhov
2015-02-03 23:12 ` [PATCH 0/8] Asynchronous device/driver probing support Dmitry Torokhov
2015-02-07 10:06 ` Greg Kroah-Hartman
2015-03-03 21:18 ` Dmitry Torokhov
2015-03-18 16:46 ` Dmitry Torokhov
2015-03-30 23:20 [PATCH v2 " Dmitry Torokhov
2015-03-30 23:20 ` [PATCH 7/8] module: add core_param_unsafe Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbk2atx1.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=arjan@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=olof@lixom.net \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome