From: ebiederm@xmission.com (Eric W. Biederman)
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tejun Heo <tj@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: WTF: driver-core-next contains recursive directory removal!
Date: Wed, 30 Oct 2013 15:57:37 -0700 [thread overview]
Message-ID: <87vc0etli6.fsf@xmission.com> (raw)
In-Reply-To: <20131030224444.GA9092@kroah.com> (Greg Kroah-Hartman's message of "Wed, 30 Oct 2013 15:44:44 -0700")
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> I don't think there's an issue here, otherwise both Tejun and I would
> have found some issues during testing, same for all of the other
> linux-next users for the past few weeks.
There issues were subtle and hard to detect especially without
instrumenting the code during pci hotplug to look for them. Memory
leaks, use after free, and needing pci hotplug to reproduce them made
the kinds of bugs I saw when I was working with it easy to go unnoticed
in light testing.
Beyond that the code has the deep issue that the code breaks normal
filesystem expectations in a way that is certain to confuse filesystem
people like Al Viro.
And yes that code being at all recursive is one of the things that Viro
objected to when you had him review sysfs before merging my cleanups
long ago.
Recursive removal is absolutely unnecessary, and it hides bugs, and
makes the code unnecessarily complex for no good reason.
Eric
next prev parent reply other threads:[~2013-10-30 22:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 22:38 Eric W. Biederman
2013-10-30 22:44 ` Greg Kroah-Hartman
2013-10-30 22:57 ` Eric W. Biederman [this message]
2013-10-31 15:24 ` Tejun Heo
2013-10-31 1:19 ` Eric W. Biederman
2013-10-31 15:29 ` Tejun Heo
2013-10-31 13:17 ` Bjorn Helgaas
2013-10-31 15:02 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc0etli6.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome