From: Andi Kleen <andi@firstfloor.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
Stephane Eranian <eranian@google.com>,
robert.richter@amd.com, Cyrill Gorcunov <gorcunov@gmail.com>,
paulus@samba.org, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [DRAFT PATCH 2/3] perf: Implement Nehalem uncore pmu
Date: Mon, 08 Nov 2010 13:20:13 +0100 [thread overview]
Message-ID: <87vd48qa6a.fsf@basil.nowhere.org> (raw)
In-Reply-To: <1288682905.12061.109.camel@minggr.sh.intel.com> (Lin Ming's message of "Tue, 02 Nov 2010 15:28:25 +0800")
Lin Ming <ming.m.lin@intel.com> writes:
Looking at a an old patch.
> +
> +static void uncore_pmu_disable_events(void)
> +{
> + struct uncore_cpu_hw_events *cpuc = &__get_cpu_var(uncore_cpu_hw_events);
> + int node = numa_node_id();
Using numa_node_id() here implies this can't be used when NUMA is turned
off. Better use the package id.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-11-08 12:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 7:28 Lin Ming
2010-11-02 14:53 ` Stephane Eranian
2010-11-02 15:33 ` Lin Ming
2010-11-02 16:59 ` Stephane Eranian
2010-11-04 19:28 ` Peter Zijlstra
2010-11-05 1:30 ` Lin Ming
2010-11-08 12:20 ` Andi Kleen [this message]
2010-11-09 5:01 ` Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vd48qa6a.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@infradead.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome